Coding-standard: EarlyExitSniff fails with yield + else

[spaceemotion]

while (($data = fgetcsv($handle, 0, ',')) !== false) {
    // skip headline
    if (is_numeric($data[0])) {
        yield $data;
    } else {
        $styledOutput->writeln(print_r($data, true) . 'id is non numeric. Headline? Skipped row!');
    }
}

produces the folllowing error:

Fatal error: Uncaught PHP_CodeSniffer\Exceptions\RuntimeException: Undefined index:  in /xxxx/vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/ControlStructures/EarlyExitSniff.php on line 168 in /xxxx/vendor/squizlabs/php_codesniffer/src/Runner.php on line 606

PHP_CodeSniffer\Exceptions\RuntimeException: Undefined index:  in /xxxx/vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/ControlStructures/EarlyExitSniff.php on line 168 in /xxxx/vendor/squizlabs/php_codesniffer/src/Runner.php on line 606

Call Stack:
    0.0004     395840   1. {main}() /xxxx/vendor/squizlabs/php_codesniffer/bin/phpcbf:0
    0.0071    1583144   2. PHP_CodeSniffer\Runner->runPHPCBF() /xxxx/vendor/squizlabs/php_codesniffer/bin/phpcbf:18
    0.0620    7371880   3. PHP_CodeSniffer\Runner->run() /xxxx/vendor/squizlabs/php_codesniffer/src/Runner.php:200
    0.0656    7981576   4. PHP_CodeSniffer\Runner->processFile() /xxxx/vendor/squizlabs/php_codesniffer/src/Runner.php:434
    0.1483   10042576   5. PHP_CodeSniffer\Reporter->cacheFileReport() /xxxx/vendor/squizlabs/php_codesniffer/src/Runner.php:656
    0.1484   10061256   6. PHP_CodeSniffer\Reports\Cbf->generateFileReport() /xxxx/vendor/squizlabs/php_codesniffer/src/Reporter.php:285
    0.1484   10044744   7. PHP_CodeSniffer\Fixer->fixFile() /xxxx/vendor/squizlabs/php_codesniffer/src/Reports/Cbf.php:49
    0.1506   10067360   8. PHP_CodeSniffer\Files\LocalFile->process() /xxxx/vendor/squizlabs/php_codesniffer/src/Fixer.php:174
    0.1506   10067360   9. PHP_CodeSniffer\Files\LocalFile->process() /xxxx/vendor/squizlabs/php_codesniffer/src/Files/LocalFile.php:91
    0.2097   10947432  10. SlevomatCodingStandard\Sniffs\ControlStructures\EarlyExitSniff->process() /xxxx/vendor/squizlabs/php_codesniffer/src/Files/File.php:496
    0.2097   10947432  11. SlevomatCodingStandard\Sniffs\ControlStructures\EarlyExitSniff->processElse() /xxxx/vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/ControlStructures/EarlyExitSniff.php:76
    0.2098   10949592  12. PHP_CodeSniffer\Runner->handleErrors() /xxxx/vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/ControlStructures/EarlyExitSniff.php:168

Here is the config:

<rule ref="SlevomatCodingStandard.ControlStructures.EarlyExit">
    <properties>
      <property name="ignoreStandaloneIfInScope" value="true"/>
      <property name="ignoreOneLineTrailingIf" value="true"/>
      <property name="ignoreTrailingIfWithOneInstruction" value="true"/>
    </properties>
</rule>

It does work, when I remove the } else { block beforehand.

[kukulich]

Thank you for your report.

Fixed in https://github.com/slevomat/coding-standard/commit/23a258ecc7d620690cdb0f98ac0b4ee0054c5ea8

[spaceemotion]

Hey, I actually got a follow up on this. Turns out, that "yield" is continuing execution afterwards and thus can't be used like a normal "continue" or "break". Which means that the previous code was actually correct, as it used else (sorry!).

what the fixer should have done is:

while (($data = fgetcsv($handle, 0, ',')) !== false) {
    // skip headline
    if (is_numeric($data[0])) {
        yield $data;
        continue;
    }

    $styledOutput->writeln(print_r($data, true) . 'id is non numeric. Headline? Skipped row!');
}

(or just left it alone)

[kukulich]

Fixed in https://github.com/slevomat/coding-standard/commit/0328bed6233710086ce2c7710af3d827fd1e00c8

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.