Coding-standard: Suggestion: forbid protected members in final classes

[alcaeus]

Protected members (constants, properties, methods) make no sense in final classes, as it amounts to them being private. Thus, a sniff should mark protected members in final classes as errors and auto-fix them to being private.

This also helps only expose selected API if the final keyword is removed from the class at a later stage to open it for extension.

[OskarStark]

This one is helpful too:

[Majkl578]

This can't be reliably implemented for classes with ancestors.
If the ancestor declares a protected method (could be abstract or not) and the final class overrides (implements) it PHPCS can't reliably detect this.

Imagine:

abstract class Foo
{
    abstract protected function getName() : string;
}

final class Bar extends Foo
{
    protected function getName() : string
    {
        return 'John Doe';
    }
}

Same applies to properties. Such sniff could work for consts though.

[alcaeus]

Right, so this would definitely have to be implemented in a static analyser. Closing here since this would generate false positives.

[Majkl578]

Btw just realized while browsing issues in phpstan-strict-rules repo this was a dupe of #754 & has FR in phpstan-strict-rules (where this is possible): https://github.com/phpstan/phpstan-strict-rules/issues/57. 😄

[alcaeus]

LOL. I’ll probably suggest it again next year. The signs of getting older...

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.