Coding-standard: UselessParenthesesSniff

[kukulich]

https://github.com/doctrine/doctrine2/pull/7297#discussion_r200220249

[kukulich]

Implemented in https://github.com/slevomat/coding-standard/commit/f7feec44cdaf9d9b290217afdd03d47978740e43

I'm open for more ideas what should be reported as useless parentheses.

[carusogabriel]

@kukulich Looks like this wasn't catch https://github.com/doctrine/coding-standard/pull/70/files#diff-ed68ee80435e5b99183806044803ac8bR21

[kukulich]

@carusogabriel Please try again :)

[carusogabriel]

@kukulich Thank you, it works. I'll test in a large codebase during the week and give you feedback in more cases we can use it, or it's fine as it's. I've found a bug:

return new class ($number) { // The Sniff reports and removes this parentheses :(
}

[kukulich]

@carusogabriel Fixed :)

[carusogabriel]

@kukulich Some other cases we can cover:

function testing() {
-    return ! (in_array($foo, ['bar', 'foo']));
+    return ! in_array($foo, ['bar', 'foo']);
}

function casting() {
-   return (bool) (intval($foo));
+   return (bool) intval($foo);
}

[kukulich]

@carusogabriel Done

[Levivb]

I've encountered another false positive:

$rowData[] = $row['function']($item);

It 'fixes' it to:

$rowData[] = $row['function']$item;

which of course is invalid php

[kukulich]

Fixed in https://github.com/slevomat/coding-standard/commit/fbdda3e0d7b6a12c4964778a3443c3883d9503a3

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.