Codesandbox-client: Links to elements don't work

[SaraVieira]

🐛 bug report

Description of the problem

Adding a link to a certain element will not work on codesandbox

How has this issue affected you? What are you trying to accomplish?

trying to navigate to an id

Link to sandbox: link (optional)

Your Environment

| Software | Name/Version |
| ---------------- | ------------ |
| Сodesandbox |PROD-1564153504-2b37aae59
| Browser |Chrome
| Operating System |Mac

[karlhorky]

Super interesting bug! This code seems like it could be related:

https://github.com/codesandbox/codesandbox-client/blob/bdfd72846324af470bca71693a2f04df1c593d30/packages/sandbox-hooks/url-listeners.js#L99-L138

[armujahid]

@SaraVieira Navigation to ids are working fine in your sandbox so I think this issue is fixed. (Tested on Firefox 69.0 (64-bit) on LInux)

[karlhorky]

@armujahid Hm, still not working for me... (macOS Chrome 76.0.3809.132)

[armujahid]

@karlhorky you are right. I tested it on Chrome 76.0.3809.132 (Official Build) (64-bit) on Linux and it's not working in both "Project View" and "New Window". So this is not a macOS exclusive issue.

[armujahid]

Related: https://github.com/codesandbox/codesandbox-client/pull/198
But that code only affects history in iframe (Project View). New tab view shouldn't be affected by it.
I also noticed another interesting thing. If we directly open https://1ybpg.csb.app/ (in incognito window) without using "Open in New Window" button then id navigation works fine in chrome.

[Oliver84]

I'm seeing this same issue. Any sandbox you build with a static HTML5 have this issues when trying to navigate to an internal ID on the page.

[moekhalil]

Please fix this. I sadly wasted hours that I will not be getting back due to this issue.

https://github.com/codesandbox/codesandbox-client/issues/4527

[github-actions[bot]]

This issue has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

[armujahid]

This issue is still not resolved so I think this shouldn't be closed :)

[SaraVieira]

It is finally fixed 🎉

[karlhorky]

Awesome, thanks @SaraVieira !