Codesandbox-client: Template buttons are not accessible

[NullVoxPopuli]

🐛 bug report

Description of the problem

How has this issue affected you? What are you trying to accomplish?

I cannot ctrl+click templates to open them in a new tab.
I cannot right click a template button to get the link to share with someone.

The template buttons are not links, and kinda goes against A11y efforts

A fix should convert these to anchor tags with href populated

[CompuIves]

That's indeed very bad. In the case of the New Sandboox Page (codesandbox.io/s) we should pass a prop to the modal to show a elements instead. In the case of the dashboard it makes a bit less sense to show a because it does a POST request to create a sandbox, but we should at least make it a button there.

For anyone wanting to pick this up, the code is here: https://github.com/CompuIves/codesandbox-client/blob/68361c3050c7403fdda5a08cacacaf067f471d35/packages/app/src/app/pages/Dashboard/Content/CreateNewSandbox/Modal/Template/index.js

[tinahir]

Can I work on this bug?

[SaraVieira]

Issue fixed in #1761

[NullVoxPopuli]

This did not fix the issue

Navigation links should be anchor tags with hrefs :-\

I can't control click a template have it open in a new window with the current implementation.
I also can't hover over the button and see what the URL is (supported by native anchor tags / hrefs :) )