Codesandbox-client: Vim mode not working in firefox

[guyfedwards]

🐛 bug report

Description of the problem

How has this issue affected you? What are you trying to accomplish?

Vim plugin does not load on Firefox

Link to sandbox: https://codesandbox.io/s/vy8p1kr2j3

Your Environment

| Software | Name/Version|
| ---------------- | ---------- |
| Сodesandbox | PROD-1554195707-bfa032269
| Browser | Firefox Quantum 66.0 for Fedora
| Operating System | Arch linux

[CompuIves]

Hmm, I'll take a look at this today. Interesting error, I hope that it's not this error (https://stackoverflow.com/questions/49816707/firefox-invalid-regex-group), as this would probably affect how the vim plugin works.

[guyfedwards]

That seems likely. There was a VS Code issue with the same error
https://github.com/VSCodeVim/Vim/issues/3522 which was fixed with an
update, not sure if that's something that can be applied here?

On Wed, 3 Apr 2019, 13:27 Ives van Hoorne, [e-mail] wrote:

Hmm, I'll take a look at this today. Interesting error, I hope that it's
not this error (
https://stackoverflow.com/questions/49816707/firefox-invalid-regex-group),
as this would probably affect how the vim plugin works.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CompuIves/codesandbox-client/issues/1704#issuecomment-479467449,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtgFwY3DGWLZ8wXht3awze_jGBJVI0pks5vdJ4ggaJpZM4caWUN
.

[CompuIves]

Ahh, nice find! It seems like the branch wasn't merged in the end, I'll make a comment: https://github.com/VSCodeVim/Vim/pull/3525.

[bpierre]

The branch got merged, does it means that this issue is going to be fixed in the next codesandbox-client release?

[manchicken]

This is still happening.

[bpierre]

Any update on this issue? I still get the error when trying to use the editor :-(

[bogas04]

https://github.com/codesandbox/codesandbox-client/pull/2260 removes it for FF due to lack of time. Not sure if it'll be fixed anytime soon, but sharing the status update here.

[bpierre]

@bogas04 I thought it was a VSCodeVim issue that had been fixed since? https://github.com/VSCodeVim/Vim/pull/3525

[github-actions[bot]]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

[SaraVieira]

Good news!

This was actually fixed today 🎉🎉🎉

https://github.com/codesandbox/codesandbox-client/pull/4831