Codesandbox-client: text selection clipboard issues under ubuntu

[eps1lon]

🐛 bug report

Description of the problem

Selecting a text and pasting text from the clipboard does not replace the selection but moves the cursor to the end of the selection.

How has this issue affected you? What are you trying to accomplish?

Basic text editing

Link to sandbox: link (optional)

Your Environment

| Software | Name/Version|
| ---------------- | ---------- |
| Сodesandbox | PROD-1553261537-e53862f6e
| Browser | Chrome Version 73.0.3683.75 (Official Build) (64-bit)
| Operating System | Ubuntu 18.04.2 LTS

[lbogdan]

That's very weird behavior, indeed, unfortunately I can't replicate it here, on either Windows or macOS.

[eps1lon]

Indeed. If I use a windows machine through browserstack.com it is working.

[doasync]

When you select any text it is automatically copied to clipboard. It's a very annoying bug 🕷

Environment:
Chrome Version 73.0.3683.86 (64-bit)
Ubuntu 18.04.2 LTS

[doasync]

@eps1lon, I suggest you to rename the issue to something like "Autocopying text on selection"

[eps1lon]

@eps1lon, I suggest you to rename the issue to something like "Autocopying text on selection"

But this is not my original issue. Maybe it's related, maybe not.

[AniaMakes]

@doasync I have the same issue (any text selected is automatically copied to the clipboard)

Chrome Version 73.0.3683.86 (Official Build) (64-bit)
Ubuntu 16.04 LTS

[lbogdan]

@CompuIves I guess you'll have to install Ubuntu on your MacBook? 😃

[eps1lon]

I could take a look as well. I just don't have any idea where to start.

[lbogdan]

It's probably something deep inside the VSCode internals, so I have no idea, either. @CompuIves , can you please advise?

[lbogdan]

@eps1lon In the meanwhile, you could start by reading the contributing guide and making CodeSandbox work locally, if you haven't already.

[eps1lon]

Sure did. I already came in contact with the vscode-editor files in #1625. I'm not sure where those come from or what the difference between vscode and monaco is. I could only find a repo to the monaco editor and I have no clipboard issues in that playground.

[CompuIves]

I found the cause of the issue! It was caused by some Linux clipboard override by VSCode, but this doesn't really work in the browser. Line is here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/contrib/codeEditor/browser/selectionClipboard.ts#L95.

I changed this line:
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/contrib/codeEditor/browser/selectionClipboard.ts#L26

to

if (platform.isLinux && !platform.isWeb)

to fix it.

I couldn only find a repo

I realized that only my local clone of the repo has the vscode repo with it. I'll make it possible for everyone to look into it.

This fix will be live in a couple hours. Sorry for this inconvenience!

[eps1lon]

This fix will be live in a couple hours. Sorry for this inconvenience!

Glad to hear, thanks. Really enjoyed the v3 release so far. Big :+1: to the whole team.

[AniaMakes]

Thank you for prompt action on this!

[CompuIves]

Fix is live! Let me know if it worked 😄.

You might have to refresh twice to see the update (service worker), the version is bfa0322 which you can see in the bottom left.

[eps1lon]

Works like a charm. Thanks!

[CompuIves]

Niiiiice! Closing this one then 😄