Codesandbox-client: Directory title length increase

Created on 2 Nov 2018  路  5Comments  路  Source: codesandbox/codesandbox-client

馃悰 bug report

Description of the problem

Importing from a GitHub repository dance2die/JavaScript30 displays should be at least 32 character(s) messages.

codesandbox import error

How has this issue affected you? What are you trying to accomplish?

Unable to import GitHub repository in CodeSandbox thus wasn't able to import the repository.

Your Environment

| Software | Name/Version|
| ---------------- | ---------- |
| 小odesandbox | Import from GitHub

Additional Context

This is a reminder for @CompuIves as requested in Discord.

image

Most helpful comment

I can confirm that the commas were indeed the issue so I removed them from my fork.

All 5 comments

Just deployed an update that doubles the max length!

Oh, new problem... I think the directory/module titles don't pass our format validation: /^[^<>:;,?"*|\/]+/. I believe I took this one from the Windows format validator, so it's interesting that the file is correctly hosted on GitHub 馃

I think this is the name with the issue (because of the ,): "25 - Event Capture, Propagation, Bubbling and Once"

Thank you @CompuIves. 馃憡

The repo was originally forked from Wes Bos's JavaScript 30 repo.
He uses a Mac so would it have something to do with it?

I can confirm that the commas were indeed the issue so I removed them from my fork.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Haroenv picture Haroenv  路  3Comments

andreplaranja picture andreplaranja  路  3Comments

kentcdodds picture kentcdodds  路  3Comments

waruyama picture waruyama  路  3Comments

MarcelloTheArcane picture MarcelloTheArcane  路  3Comments