Codesandbox-client: Typings files not initially found

Created on 18 Oct 2018  路  4Comments  路  Source: codesandbox/codesandbox-client

馃悰 bug report

Description of the problem

Typings are not initially found by the editor. This seems to be affecting both Monaco and VSCode editors. After a file is edited, the red underlines go away for the node_modules typings in Monaco, and everything in VSCode. This seems to be occurring on both the Dojo and React+TS templates.

screen shot 2018-10-18 at 3 26 23 pm

How has this issue affected you? What are you trying to accomplish?

The editor seems to not know about modules loaded, causing confusion.

Link to sandbox: Dojo and React+TS

Your Environment

| Software | Name/Version|
| ---------------- | ---------- |
| 小odesandbox | PROD-1539886201-8ea3d55 |
| Browser | Firefox 62, Chrome 72 |
| Operating System | macOS Mojave |

Most helpful comment

Whooh I have improved this a lot! You can now also view/edit typing files in the editor, we also download peer dependencies of types and we don't show errors initially. Exciting! Will deploy it today.

Also fixes #819 #1127 #1164.

image

All 4 comments

Interesting. It seems to me we should delay the type checking until we made sure that all the types have been downloaded. Definitely something in VSCode, I can fix it tomorrow!

Whooh I have improved this a lot! You can now also view/edit typing files in the editor, we also download peer dependencies of types and we don't show errors initially. Exciting! Will deploy it today.

Also fixes #819 #1127 #1164.

image

Amazing! Thanks so much!

It's live!

Was this page helpful?
0 / 5 - 0 ratings