Codesandbox-client: Improve import from GitHub url validation

[Hum4n01d]

There are a few improvements that could be made to the import from GitHub page. I will attempt to make these changes and submit a PR.

• The page should accept hum4n01d/hogwash-client, github.com/hum4n01d/hogwash-client, and https://github.com/hum4n01d/hogwash-client as valid GitHub repo urls
• The validator should check for github.com/username/repo rather than just github.com

Right now, it won't accept hum4n01d/hogwash-client as it doesn't contain github.com.

If I put the github link without https:// this happens:

When I click Open Sandbox, it sends me to https://codesandbox.io/s/github.com/hum4n01d/hogwash-client which is invalid.

[CompuIves]

Yes, we could definitely use better parsing!

[cantyjeffrey]

@Hum4n01d
This would be great, as I have been trying (but unable) to import https://github.com/cantyjeffrey/react-boilerplate and have tried the following combinations with no such luck:

• https://github.com/cantyjeffrey/react-boilerplate.git
• https://github.com/cantyjeffrey/react-boilerplate
• github.com/cantyjeffrey/react-boilerplate
• cantyjeffrey/react-boilerplate

Am I missing something obvious as to why I can't import this repository?

cc: @CompuIves

[Hum4n01d]

@cantyjeffrey I’ve had the same problem, though I don’t think it’s related to this issue :)

[cantyjeffrey]

I agree. I tried uploading via CLI and think that the culprit is the fact that it’s an ejected CRA repo, which puts dependencies over the 40 dependency limit. Just a guess.

[cantyjeffrey]

CLI threw error, but for GH import it’s a generic error message.

[evgenyrodionov]

Also not working with branches with /

https://github.com/mrzvdesign/aviasales-demo-frontend/tree/feat%2Fmain-page

imported as
https://codesandbox.io/s/github/mrzvdesign/aviasales-demo-frontend/tree/feat%2Fmain-page
or with manually replaced to /
https://codesandbox.io/s/github/mrzvdesign/aviasales-demo-frontend/tree/feat/main-page

leads to

An error occured when fetching the sandbox:
has invalid format

[evgenyrodionov]

Interesting, it works on another repo

https://codesandbox.io/s/github/Rainbowhorseproduction/aviasales-demo-frontend/tree/feat%2Fmain-page

[CompuIves]

Found the issue @evgenyrodionov 😄. There was a file with a different unicode character than 'c', but it looked like 'c'. I changed the file validation to make it work. Should work now.

[CompuIves]

Just took a look at your sandbox @cantyjeffrey, the project will work if you put all dependencies that are used for building are put in devDependencies in package.json. We will autodetect used dependencies in the future 😄

[CompuIves]

I'll close this one now since the initial GitHub URL converter issues are fixes. For any new issues we can open a new issue.