Codesandbox-client: White theme

[CompuIves]

Would be nice to have an optional white theme for embeds and editor for people that prefer it.

[farskid]

I'd like to help with this issue. Any particular steps to start from?

[CompuIves]

Ahh that's absolutely perfect @farskid!

We're already using styled-components and our styles are defined in common/theme.js. It may be too good to be true, but maybe just changing those colors will already make it possible to create a light theme. That would be a very good start.

[farskid]

@CompuIves Very nice! I'll start right away and will keep this issue posted :)

[steventsao]

IMO, the font colors need to be darkened to increase contrast in a white background. We'll also need to update the backgroundColor in tabs, user highlights, and maybe the autocomplete popover.

[aleksspeaker]

Hello, I just want to mention that, we're waiting patiently for day theme.
;)

[farskid]

@aleksspeaker Sorry for the delay. I'll try to ship it soon

[aleksspeaker]

@farskid No worries.
I want you to know that we're (or at least I'm) with you. :)
If you need something - just drop me a line here.

[CompuIves]

I'm also taking a look at this combined with theme support! @farskid, curious what you already have 😄

[Haroenv]

Can be closed!!!

[farskid]

@CompuIves Sorry for not delivering this and late responses :(
Just seen the support for theme :)
Glad we have this right now and so sad to miss the chance.
Great Job!

[CompuIves]

Hey @farskid! I'm so sorry for bumping in there and doing this suddenly, I was very enthusiastic about getting the vscode themes to work and went a bit overboard. I hope I've not wasted too much of your time here :(.

[CompuIves]

Also, let me know if you want a walkthrough of how I did it! I'd gladly do that.

[steventsao]

Walking through this list of commits is already helpful, thanks! https://github.com/CompuIves/codesandbox-client/pull/647

[farskid]

@CompuIves I'd love to have a walkthrough :)
And btw, no worries about this, you did a great job as usual :)

[aleksspeaker]

Thanks, everyone!
Works great!
Finally!!!))) 🎉

[sinedied]

Is there any way to force a specified theme (ie VSCode Light instead of default dark for example) for embeds? I could not find any way to do that

[sisardor]

Any updates or how to enable the white theme on embeds?