Codesandbox-client: ReasonML support

[johann-sonntagbauer]

First of all I am very impressed by the excellent work. The online editing experience is very pleasing.
I would like to invest time to build ReasonML support for code sandbox. The basic infrastructure is very well layed out already and I think ReasonML could be integrated quite well.
Please let me know if you think the idea could be benifitial for your project as well as ReasonML.

Some links as background information

official documentation
https://reasonml.github.io/

visual studio code plugin
https://github.com/reasonml-editor/vscode-reasonml

[CompuIves]

Yep! This is a much wanted feature. I'm starting with a rewrite of the loader system right now, which should make it easier to allow loaders like BuckleScript to exist. I'm planning to finish that this week.

The biggest unknown for me with ReasonML is how we are going to support the syntax in Monaco, vscode extensions are partially convertible to Monaco. So we could handpick the extension to add support to Monaco.

[johann-sonntagbauer]

Nice! I could start with the ground work to get the Editor setup with all necessary pieces of the plugin already.

[CompuIves]

That would be really great. It would help a ton!

[tomsdev]

Any progress on this? This could really impact ReasonML adoption (and codesandbox!)

[CompuIves]

Yep, there has been a lot of progress on this. I released the new loader system ~10 days ago, so we are now able to very easily expand our existing templates with eg. ReasonML.

The remaining tasks for ReasonML support are:

1. Create a loader for ReasonML files using BuckleScript
2. Build better support for Reason in the Monaco editor

Point 1 isn't a lot of work, but point 2 is pretty big. I'm not sure if there has been previous work on this. We can't release ReasonML support if the editor doesn't understand it.

I want to add that @rebornix recently took the Vetur extension and ported it to Monaco (https://github.com/rebornix/monaco-vue). Maybe he has some pointers on how to approach converting https://github.com/reasonml-editor/vscode-reasonml to Monaco.

[rebornix]

The major differences between VSCode API and Monaco API are:

• VSCode API is declarative, Monaco one is more functional.
• VSCode extension runs in extension host, which is a node process. Monaco language services run in web worker.
• VSCode extensions are nodejs apps while Monaco extensions run in browser, so the language can only be JS/WASM.

I'll write a detailed guidance about how to convert from VSCode extension to Monaco.

[CompuIves]

That would be really helpful! Thanks a lot 😄

[lbogdan]

Is there any ongoing effort to add vetur to codesandbox?

[rebornix]

@lbogdan https://github.com/rebornix/monaco-vue ports Vetur to Monaco, which is used by codesandbox.

[rebornix]

There is already a LSP for ocaml https://github.com/freebroccolo/ocaml-language-server , which is used by VSCode-Reason as well. Since it's written in TypeScript, so it can be ported to Monaco the same way as monaco-vue.

[rebornix]

After digging into https://github.com/freebroccolo/ocaml-language-server for a while, this task turns out to a bit complex (whcih means it requires more than one day or two to finish) since https://github.com/freebroccolo/ocaml-language-server doesn't have an abstraction of Language Service which can be shared in both local env and browser. One good approach can be tweaking ocam lsp by https://github.com/Microsoft/vscode-css-languageservice/blob/master/src/cssLanguageService.ts#L56 and then we can easily write a Monaco ext for reasonml.

[ghoullier]

Hi!
Seems ReasonML support is very near 🎉

https://twitter.com/jaredforsyth/status/997148166318411778

[CompuIves]

Yep, starting to work on it now again!

[johann-sonntagbauer]

@CompuIves is there anything I can support you with?

[ghoullier]

Hi! @CompuIves and sorry for the spam.
Did you plan to continue to work on this feature?

[SaraVieira]

This has been implemented 🎉🎉