Code-settings-sync: Open Show "Share ID" Message when new Public Gist is created

[inwardmovement]

Every time I open VSCode I have this notification:

Sync: Share the Id with other extension users to share the settings.

How can I get rid of it permanently?

---

🌴 Visual Studio Code Version : 1.36.1
🌴 Code Settings Sync Version : 3.4.1
🌴 Standard or Insiders : Standard
🌴 Portable or Installed : Installed
🌴 OSS or Official Build : Official Build
🌴 Operating System : Windows 10
🌴 Occurs On: "Sync uploaded successfully" (each sync)
🌴 Proxy Enabled: yes (I guess it's default VSC value, I didn't change anything)
🌴 Gist Id: 1b8b7717469c2648bacb57a1498dd84e

📰 To Reproduce
Steps to reproduce the behavior:
Modify a setting and upload settings

💪 Expected behavior
No notification at each sync

📺 Console Error Log

📺 Additional context
gist

[shanalikhan]

Can you post your Settings Sync global settings.

https://github.com/shanalikhan/code-settings-sync#global-settings

[inwardmovement]

Here they are:

{
    "ignoreUploadFiles": [
        "state.vscdb",
        "state.vscdb.backup",
        "syncLocalSettings.json",
        ".DS_Store",
        "sync.lock",
        "projects.json",
        "projects_cache_vscode.json",
        "projects_cache_git.json",
        "projects_cache_svn.json",
        "gpm_projects.json",
        "gpm-recentItems.json",
        "state.*"
    ],
    "ignoreUploadFolders": [
        "workspaceStorage"
    ],
    "ignoreExtensions": [],
    "gistDescription": "Visual Studio Code Settings Sync Gist",
    "version": 340,
    "token": "(anonymized)",
    "downloadPublicGist": false,
    "supportedFileExtensions": [
        "json",
        "code-snippets"
    ],
    "openTokenLink": true,
    "disableUpdateMessage": false,
    "lastUpload": "2019-06-27T09:13:31.267Z",
    "lastDownload": "2019-07-22T08:50:55.815Z",
    "githubEnterpriseUrl": null,
    "askGistName": false,
    "customFiles": {
        "projects.json": "C:\\Users\\arkay\\AppData\\Roaming\\Code\\User\\globalStorage\\alefragnani.project-manager\\projects.json",
        ".gitconfig": "C:\\Users\\arkay\\.gitconfig",
        "Greenshot.ini": "C:\\Users\\arkay\\AppData\\Roaming\\Greenshot\\Greenshot.ini",
        "default.svg": "C:\\Users\\arkay\\AppData\\Roaming\\Inkscape\\templates\\default.svg",
        ".editorconfig": "C:\\Users\\arkay\\Documents\\config\\.editorconfig",
        "autoload.bat": "C:\\Users\\arkay\\Documents\\config\\autoload.bat",
        "info.txt": "C:\\Users\\arkay\\Documents\\config\\info.txt",
        "remove-safely-icon.bat": "C:\\Users\\arkay\\Documents\\config\\remove-safely-icon.bat",
        "macros.ahk": "C:\\Users\\arkay\\Documents\\config\\macros.ahk",
        "run.ahk": "C:\\Users\\arkay\\Documents\\config\\run.ahk",
        "text.ahk": "C:\\Users\\arkay\\Documents\\config\\text.ahk"
    },
    "hostName": null,
    "universalKeybindings": false,
    "autoUploadDelay": 20
}

[inwardmovement]

Fixed in 3.4.1, thanks!

[inwardmovement]

The notification showed again, sorry.

[shanalikhan]

alright, pls post the gist ID

[inwardmovement]

1b8b7717469c2648bacb57a1498dd84e

[shanalikhan]

Can you post the details with the proper issue template so I can see the reproducing steps , happeing on upload / download etc. I have updated your main post so you can fill it up.

[inwardmovement]

Ok thanks, done

[inwardmovement]

Any news on this?
I think we should have a "Do not show again" option in the "gear" icon menu of the notification, like other notifications in VSCode.

[shanalikhan]

I didn't find time to fix this issue. Hopefully, it will be fixed in upcoming releases. :)

[shanalikhan]

It is fixed and released in new version.

[pcdevil]

Hello,

Since the new release I see this message (but previously I wasn't). I see the checks on this changed in the last release:

Previously the condition looked at the localConfig.publicGist variable (see L407) but now just for optArgument.
But the way as the optArgument becomes _true_ is different (in terms of this check): if the incoming variable is _trueish_, the message will be showned, meanwhile previously it not just checked for _emptiness_, it checked for it's value too (see L87-88).

Since I don't see the calling signature is changed (as of the extension.ts L19-21) I would assume this is not how it should work?

I think reverting the modification in the sync.ts L407 would solve the issue, or a direct check on optArgument:

-          if (optArgument) {
+          if (optArgument === "publicGIST") {

What is your thoughts on this @shanalikhan?

[shanalikhan]

yes are you right. I will place the check on optArgument value too.

localConfig.publicGist can remain to true forever and user were seeing this message on every update. Now notification needs to be only appear when user creates new public gist. ( not on every upload on public gist, afterwards)

[pcdevil]

Ohh I see! I missed that part of the code, sorry :)