Code-server: Escape key shortcuts, esp in Find pane, make active editor lose focus

[arseniybanayev]

I think that https://github.com/cdr/code-server/issues/638 may be related.

I have all of the default Escape and Shift+Escape keyboard shortcuts mapped, esp. for
editor.action.webvieweditor.hideFind
closeFindWidget

but when I hit the Escape key to exit the Find pane in an editor, focus is lost from the entire editor. I expect the Find pane to disappear. I have to hit Ctrl+1 or use the mouse to regain focus on the editor, as mentioned in that other issue above.

I am using the latest version of code-server, running from a Docker container from Docker Desktop for Windows and using Chrome Version 80.0.3987.149 to view, but this has been present in many versions in the past. I just waited until now to mention :)

[cmoog]

Have you tried installing the Chrome web app? I think it should resolve you keybind conflicts.

[kylecarbs]

Closing because of inactivity. Installing the Chrome app should fix all these problems 🎊

[arseniybanayev]

This was resolved in version 3.1.1 with no change on my part, no Chrome app.

[fiibbb]

Closing because of inactivity. Installing the Chrome app should fix all these problems 🎊

I’m hitting the same issue on 3.3.1

Could you clarify what you mean by Chrome app? Do you mean there’s chrome extension somewhere?

This is especially frustrating since I use vim mode

[cmoog]

@fiibbb Once you've entered the editor, click the "plus" icon present int he URL toolbar area. This will install a Chrome PWA.

[nhooyr]

We should add a FAQ entry for that.

[anddam]

@fiibbb Once you've entered the editor, click the "plus" icon present int he URL toolbar area. This will install a Chrome PWA.

I do not have such an icon.

For those who do not see it either, it is shown in this Google Chrome support page.

I am using docker image ece4f1a1e6ae from 4 weeks ago, what info can I provide to figure why is this?

[anddam]

@fiibbb Once you've entered the editor, click the "plus" icon present int he URL toolbar area. This will install a Chrome PWA.

I do not have such an icon.

For those who do not see it either, it is shown in this Google Chrome support page.

I am using docker image ece4f1a1e6ae from 4 weeks ago, what info can I provide to figure why is this?

I can further elaborate on this myself: switching from plain http to https (using a self-signed certificate) while accessing the docker image from a different host did the trick.

I run the docker code-server image on host A, I publish 0.0.0.0:2000:8080 (for some reason I cannot bind the server to 443 like in the guide) then I access https://A:2000/ from host B.
Escape key is working as expected (exiting multi-line cursor, for instance) and C-w always close the editor tab, not the browser page.

As it is I have no problem with keys now.

[mjarkk]

This still seems to be an issue on chrome OS even when installing the chrome app 😞

[anddam]

This still seems to be an issue on chrome OS even when installing the chrome app

Is this in full-screen and, if so, how did you enter full-screen mode?

[mjarkk]

@anddam THANKS!!
Via ctrl + shift + P > enter full screen the escape key works as expected.

[anddam]

@anddam THANKS!!

yw

Via ctrl + shift + P > enter full screen the escape key works as expected.

I got quite frustrated a few months ago, when suddenly Esc key was being catched by the browser again exiting full-screen, this was a change happening outside my config.

It turns out that entering in full-screen via the Chrome menu ⋮ > [ ] provides a "full-screen app" behavior with Esc key handled inside the app, whereas using F11 to enter full-screen makes Esc key being handled by the browser.

Your going through the vscode command is a third way, I'll check it out of curiosity to see which of the two behavior it gives me (I am not running this on Chrome OS).