Code-server: Intellij Idea Keybindings clipboardPasteAction not found

[NickBolles]

• code-server version:

code-server --version
v10.15.1

• OS Version: docker
• Extension: Intellij Idea Keybindings

Description

When pasting in the editor I get a "editor.action.clipboardPasteAction' not found toast notification and pasting fails. But copying works successfully.

I can also copy and paste just fine in the terminal.

Issue on the extension repo: https://github.com/kasecato/vscode-intellij-idea-keybindings/issues/163

Steps to Reproduce

[code-asher]

Interesting, looks like VS Code web doesn't support that command at the moment. I imagine they could do it with the clipboard API but they only use that for the terminal at the moment.

[NickBolles]

For anyone else finding this, I just overrode this keybinding with the following in my keybindings.json file

  // Remove incompatible paste action
  {
    "key": "ctrl+v",
    "command": "-editor.action.clipboardPasteAction",
    "when": "editorTextFocus && !editorReadonly"
  },

[danger89]

Uh.. yup something is wrong. I'm using v2 of code-server.

[code-asher]

You might be running into this: https://github.com/cdr/code-server/issues/1106

If so, the best solution is to use HTTPS. There's a workaround for pasting but I'm not sure there's one for copying (it might work to just unbind it).

[danger89]

I'm using HTTPS. But I'm using Nginx reverse proxy in between.

EDIT: Lets put it differently, I do not need the HTTPS from code-server. I can use plain communication between Nginx and the localhost:8080, and my separate Nginx reverse proxy server is taking care of the SSL stuff (which is running on port 443, publicly available).

[code-asher]

EDIT: Lets put it differently, I do not need the HTTPS from code-server. I can use plain communication between Nginx and the localhost:8080, and my separate Nginx reverse proxy server is taking care of the SSL stuff (which is running on port 443, publicly available).

That sounds good; I use the same setup. As long as the browser itself is seeing an HTTPS all is well. But I realized I missed some information about Firefox so I elaborated here: https://github.com/cdr/code-server/issues/1106#issuecomment-548911682

[bgold0]

Should note that pasting works fine when nothing is selected. It's only when things are selected that you get this error.

[NickBolles]

Should note that pasting works fine when nothing is selected. It's only when things are selected that you get this error.

My initial issue was happening whether or not I had anything selected. That issue is resolved (by removing the command in the intellij extension). Maybe we should create a new issue for any other root causes.

[nhooyr]

Upstream issue.

[nhooyr]

Not really an upstream issue, we should just patch it, it'd be really easy afaik.

[nhooyr]

Only for chromium based browsers and Firefox though, safari doesn't support the clipboard API we'd need.

[nhooyr]

Or actually, I wonder what they do for the terminal in Safari.

[nhooyr]

Yea I'm actually confused how the terminal supports copying since it's rendering to a canvas so I can't select any text and so document.execCommand("copy") wouldn't work.

[nhooyr]

Figured it out. See https://github.com/xtermjs/xterm.js/blob/7f598a36753f4d950ee63dc91bd6a92290f7e037/src/browser/Clipboard.ts

They have a DOM element they populate right before a selection occurs to ensure the DOM is in sync with what's actually being selected.

[nhooyr]

Oh, nvm, check this out: https://developer.mozilla.org/en-US/docs/Web/API/Element/copy_event

That's what they're using. Not sure what the above is about then.

[nhooyr]

Mhmm, same with pastes: https://github.com/xtermjs/xterm.js/blob/7f598a36753f4d950ee63dc91bd6a92290f7e037/src/browser/Clipboard.ts#L45