Code-server: Broken syntax highlighting on PHP files.

[endridev]

• code-server version: 1.31.1-100
• OS Version: Ubuntu 16.04
  

  Steps to Reproduce

1. Create a blank PHP file.
2. Start coding by using if ( isset( $some_variable ) .... You'll notice that the syntax is broken after isset().

Attached to this report you'll find a screenshot related to this as well. Amazing product anyways :+1: :smile:

[nhooyr]

Does this work in vscode?

[nhooyr]

@kylecarbs we're using vscode's syntax highlighting right so this shouldn't be a bug in code-server?

[kylecarbs]

Correct(ish). We use a wasm port of the library VS Code uses. It's possible there's an issue with that.

[NGTmeaty]

Vanilla VSCode does seem to work correctly:

[endridev]

I second NGTmeaty. Here is my vanilla VSCode installation.

[kylecarbs]

Def something wrong here. Will investigate.

[pwFoo]

I need to install php-cli to get php highlighting working without error message. Maybe add php-cli to docker image?

[foresthoffman]

@pwFoo What was the error message that you received?

[pwFoo]

Without php-cli installed the message is that no php is found. Installed it in console fixes that, but highlighting has delay. It needs some time (maybe a half minute?) until directories and files are colored (local code is initially cloned from git) and code changes from plain to highlighted.

[code-asher]

v2 finally fixed this (https://github.com/cdr/code-server/commit/07ec4ca63e5a735315a6cb71f8379556b481924c) by downgrading onigasm https://github.com/NeekSandhu/onigasm/issues/17.