Code-server: packaging: remove windows/macOS support in favour of using docker
Will make our CI/testing/code simpler.
Docker should be enough for pretty much every use case I can think of anyway, aside from developing windows apps or macOS apps which code-server doesn't really have good support for anyway.
Not 100% convinced this is the way to go, opening for thoughts.
@kylecarbs @coderasher
nhooyr
All 8 comments
I like this idea. This kind of application has most potential when deployed in a container, also opening a lot of possibilities for Kubernetes.
PhilsLab
on 7 Mar 2019
I'm iffy on this because Docker on Mac can be really weird sometimes, how much code would be removable if you removed macOS support?
Omeryl
on 7 Mar 2019
Not much. All the code is pretty generalized.
kylecarbs
on 7 Mar 2019
Docker on Windows is also really weird.
By the way, installing Docker for Windows enables Hyper-V, which prevents you from being able to use VMWare Workstation or Player. (Although there may be some workarounds, it's weird.
orzFly
on 8 Mar 2019
This seems to be a split response.
I love the idea of removing platforms in favor of using Docker. I suppose an issue is that code-server wasn't really designed with containment in mind.
kylecarbs
on 8 Mar 2019
Personally, I would much rather more platform support. Docker is annoying to setup on windows and imo shouldn't be forced. If we can compile a binary for it, we might as well.
NGTmeaty
on 8 Mar 2019
I prefer more plateform support.
fMichaleczek
on 23 Apr 2019
Closing, doesn't take much effort to support all platforms.
nhooyr
on 23 Apr 2019
Related issues
grant
路
3Comments
justmao945
路
3Comments
balazssoltesz
路
3Comments
infogulch
路
3Comments
oonqt
路
3Comments
Most helpful comment
Personally, I would much rather more platform support. Docker is annoying to setup on windows and imo shouldn't be forced. If we can compile a binary for it, we might as well.