Code-server: Fix password feature

Created on 5 Mar 2019  路  12Comments  路  Source: cdr/code-server


First of all, it's an awesome project. Thank you! By the way, do you plan to add fix password feature? Maybe it can be set as CLI argument like ./code-server --password 123456.

Or can I create a PR with this feature?

Keep up the good work!

Most helpful comment

Wow, this code-server is amazing, thank you for such a great new tool! we will start using it in our agency... Password parameter for sure is important, otherwise user needs to login to ssh first, run the code-editor, copy the password, and only then be able to use it in the browser.

All 12 comments

I agree

I like that Ide @icebob. I will bring it up to the front end peeps.

Wow, this code-server is amazing, thank you for such a great new tool! we will start using it in our agency... Password parameter for sure is important, otherwise user needs to login to ssh first, run the code-editor, copy the password, and only then be able to use it in the browser.

@icebob feel free to create a PR for it! We'll also put it on the high-priority list :)

Great! I will send it when I'm done.

I'm confused since according to the docs --password is a valid flag.

$ ./code-server --help
Start your own self-hosted browser-accessible VS Code

USAGE
$ server [WORKDIR]

ARGUMENTS
WORKDIR [default: /home/xxx/code-server-1.31.0-x86_64-linux] Specify working dir

OPTIONS
-d, --data-dir=data-dir
-h, --host=host [default: 0.0.0.0]
-o, --open Open in browser on startup
-p, --port=port [default: 8443] Port to bind on
-v, --version show CLI version
--allow-http
--cert=cert
--cert-key=cert-key
--help show CLI help
--no-auth

What I meant with my message is that if the flag is in the docs maybe it's a feature not pushed yet but already implemented. I don't know the roadmap, was just pointing that out.

Docs updated with #5 https://github.com/icebob/code-server/commit/e1099f0fb4240ac39f9fe788d86a2e1527724b17#diff-3e3c890e38761b2c49f651e11b921f9d
But it's not released yet.

While regular Math.Random is probably fine, we may want to look into using a CSPRNG.

why not just use /dev/urandom?

Nothing could possibly go wrong using the OS's Random device.

With Windows support coming in the future, I doubt we'd want to use a OS dependent function.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pchecinski picture pchecinski  路  3Comments

lshamis picture lshamis  路  3Comments

rcarmo picture rcarmo  路  3Comments

oonqt picture oonqt  路  3Comments

RealSlimMahdi picture RealSlimMahdi  路  3Comments