Cocoapods: Xcode 10.2 beta 2 warning: Enable Base Internationalization

[alex-vasenin]

Report

What did you do?

Run pod install.

What did you expect to happen?

Xcode shows no warnings.

What happened instead?

Xcode 10.2 beta 2 shows Enable Base Internationalization warning on Pods project. Xcode release notes states

Enabling Base Internationalization is recommended for all projects, and any projects that don’t currently use Base Internationalization are offered an upgrade even if they only have a single localization. The upgraded projects are backward-compatible with previous releases of Xcode. (15160454)

CocoaPods Environment

Stack

   CocoaPods : 1.6.0.rc.2
        Ruby : ruby 2.3.7p456 (2018-03-28 revision 63024) [universal.x86_64-darwin18]
    RubyGems : 2.5.2.3
        Host : Mac OS X 10.14.2 (18C54)
       Xcode : 10.2 (10P91b)
         Git : git version 2.20.1 (Apple Git-116)
Ruby lib dir : /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib
Repositories : master - https://github.com/CocoaPods/Specs.git @ ca3a92816774e978c816594083d67f2f17ee43a6

Installation Source

Executable Path: /usr/local/bin/pod

Plugins

cocoapods-deintegrate : 1.0.2
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.0.0
cocoapods-trunk       : 1.3.1
cocoapods-try         : 1.1.0

Podfile

platform :ios, '11.0'
inhibit_all_warnings!
use_frameworks!

workspace 'XyzExample.xcworkspace'

def xyz_pods
  pod 'TwilioChatClient'
  pod 'JWTDecode'
  pod 'PromiseKit/CorePromise'
  pod 'MBProgressHUD'
  pod 'Chatto'
  pod 'ChattoAdditions'
  pod 'PINCache'
end

target 'XyzExample' do
  project 'XyzExample.xcodeproj'
  pod 'Fabric'
  pod 'Crashlytics'
  xyz_pods
end

target 'Xyz' do
  project '../Xyz.SDK/Xyz.xcodeproj'
  xyz_pods
end

target 'XyzTests' do
  project '../Xyz.SDK/Xyz.xcodeproj'
  xyz_pods
end

post_install do |installer|
  installer.pods_project.targets.each do |target|
    if ['Chatto', 'ChattoAdditions'].include? target.name
      target.build_configurations.each do |config|
        config.build_settings['SWIFT_VERSION'] = '4.0'
      end
    end
  end
end

[dnkoutso]

Yes they probably need to be updated.

[xmollv]

Just as a confirmation, on the final version of Xcode 10.2 (10E125) the warning appears as described above.

[DenTelezhkin]

I would also add that apart from Pods project mentioned in this issue, if you use new experimental flag generate_multiple_pod_projects set to true, those warnings also appear in each CocoaPod dependency, which makes warning levels go to extreme.

@dnkoutso Maybe you can point out how Xcode project for CocoaPods generation can be updated, so I could help with PR to solve this issue as soon as possible?

[benguild]

Also seeing this on the 10.2 release build.

[kubatruhlar]

Maybe you could set the Missing localizability key in the Build Settings to false and restart Xcode.

[fsuc]

Thanks, @kubatruhlar. The following code seems to remove the warning.

post_install do |installer|
  installer.pods_project.build_configurations.each do |config|
    config.build_settings['CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED'] = 'YES'
  end
end

[kreeger]

@fsuc That doesn't seem to fix our issue; if I blow away Pods/ and run pod install after placing that code at the bottom of my Podfile, the localization warnings for the Pods project reappear.

[fsuc]

@kreeger You're right, 2 new localization warnings appear when you relaunch Xcode (there's no issue after closing and reopening the project ...). Xcode wants to remove the deprecated English development region and enable base internationalization. If the build setting is set to NO (by default in my project), an update to recommended settings warning is displayed.

[MuralidharanKathiresan]

any help/suggestion for the warning?

[MaximeLM]

The workaround by @fsuc can be updated to fix the two additional warnings:

post_install do |installer|
  installer.pods_project.build_configurations.each do |config|
    config.build_settings['CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED'] = 'YES'
  end
  installer.pods_project.root_object.known_regions = ["Base", "en"]
  installer.pods_project.root_object.development_region = "en"
end

[stanmots]

Xcode Version 10.2.1 (10E1001) still shows these warnings:

[dnkoutso]

I believe this is fixed by https://github.com/CocoaPods/Xcodeproj/pull/669. We released xcodeproj 1.9.0 can someone verify?

[stanmots]

@dnkoutso Tried CocoaPods 1.7.0.rc.1 - same issues. Also tried the new generate_multiple_pod_projects and this is what I got:

[dnkoutso]

But did you ensure xcodeproj gem is on version 1.9.0?

[stanmots]

I installed CocoaPods using this command: sudo gem install cocoapods --pre. Is there something else I need to do to ensure xcodeproj is 1.9.0?

[dnkoutso]

Yes its a different gem. 'gem update xcodeproj'.

[stanmots]

Okay, I've just rebuilt the project and everything works fine. Thanks.

[chrisvanbuskirk]

I'm still affected. Updated to rc1 and the latest version of xcodeproj.

[stanmots]

@chrisvanbuskirk Ensure that you have xcodeproj-1.9.0 properly installed. If you used sudo then check out the following path: Library/Ruby/Gems/<RubyVersion>/gems/. When I removed older versions of xcodeproj from this folder the warnings disappeared.

[chrisvanbuskirk]

@stanmots Thanks...it works now.

[dnkoutso]

It seems this is good to close then?

[DenTelezhkin]

Resolved in both 1.7.0 and 1.6.x 👍

_{Sent with GitHawk}

[dnkoutso]

For anyone following gem update xcodeproj to version 1.9.0 to fix this. Closing.

[ferrerod]

I don't think this is yet resolved. I have verified I have gem xcodeproj 1.9.0 and removed all older xcodeproj gems. I'm using cocoapods 1.7.1, bundler 1.17.1
I have tried deleting derived Xcode's derived data, I've tried bundle exec pod deintegrate then deleting Pods and workspace and recreating with install. No matter what I do the Base International warning reappears. It appears the Pods project is not keeping the flag set to Base. Thoughts?

When I run bundle exec pod install, the Pods/Pods.xcodeproj/project.pbxproj shows:

knownRegions = (
                                en,
                        );

instead of:

knownRegions = (
                                en,
                                Base,
                        );

[tache]

@chrisvanbuskirk Ensure that you have xcodeproj-1.9.0 properly installed. If you used sudo then check out the following path: Library/Ruby/Gems/<RubyVersion>/gems/. When I removed older versions of xcodeproj from this folder the warnings disappeared.

to remove older version of xcodeproj

gem uninstall xcodeproj

[chrisballinger]

This is issue has resurfaced with Xcode 11.1 and xcodeproj (1.12.0) - with generate multiple Xcode projects enabled.

[richellis]

This warning is happening again with Xcode 11.6, CocoaPods 1.9.3, xcodeproj 1.17.0. If I accept the changes Xcode makes I see this in the diff:

--- a/Pods/Pods.xcodeproj/project.pbxproj
+++ b/Pods/Pods.xcodeproj/project.pbxproj
@@ -8864,7 +8864,7 @@
                        isa = PBXProject;
                        attributes = {
                                LastSwiftUpdateCheck = 1100;
-                               LastUpgradeCheck = 1100;
+                               LastUpgradeCheck = 1160;
                        };
                        buildConfigurationList = 4821239608C13582E20E6DA73FD5F1F9 /* Build configuration list for PBXProject "Pods" */;
                        compatibilityVersion = "Xcode 9.3";
@@ -12137,6 +12137,7 @@
                        isa = XCBuildConfiguration;
                        buildSettings = {
                                ALWAYS_SEARCH_USER_PATHS = NO;
+                               CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
                                CLANG_ANALYZER_NONNULL = YES;
                                CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
                                CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
@@ -14046,6 +14047,7 @@
                        isa = XCBuildConfiguration;
                        buildSettings = {
                                ALWAYS_SEARCH_USER_PATHS = NO;
+                               CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
                                CLANG_ANALYZER_NONNULL = YES;
                                CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
                                CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";