Cockroach: ui: text selection on table schema page is cleared

[mjibson]

On a table schema page, selecting some text. The text selection is cleared after a few seconds. Very annoying behavior if I'm trying to copy it to the clipboard.

Assigning for triage. Not sure who it should go to.

[vilterp]

Oy. Looks like just the healthcheck firing is enough to cause the TableDetails component to update, which calls hljs.highlightBlock on the create table statement. This probably destroys the selection by swapping out the DOM nodes and replacing them with new ones (which are exactly the same). Prob could be fixed by implementing a shouldComponentUpdate.

[vilterp]

Can't repro this anymore. I think @couchand fixed it by adding a shouldComponentUpdate to fix the other issue where this page used more and more CPU over time because it was re-highlighting every two seconds and creating infinitely nested DOM nodes.

[mjibson]

Confirmed this appears fixed for me.