Cockroach: convert Examples in client/db_test.go to regular tests

Created on 18 Apr 2016  Â·  5Comments  Â·  Source: cockroachdb/cockroach

Peter Mattis said, "We should change all of these Example tests to regular tests. Using examples was useful when this was a public api, but less so now that it is internal. Example-style tests seem to be slower than regular tests."

E-easy help wanted

Most helpful comment

Wow you got a lucky number. Ill take a look tonight

On Sat, May 14, 2016, 11:04 AM Thanakom sangnetra [email protected]
wrote:

@vivekmenezes https://github.com/vivekmenezes I have opened the PR in

6666 https://github.com/cockroachdb/cockroach/pull/6666

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cockroachdb/cockroach/issues/6101#issuecomment-219225114

All 5 comments

Hi, @vivekmenezes i will work on this

Awesome! Thanks for taking it on

On Sun, May 8, 2016, 12:49 AM Thanakom sangnetra [email protected]
wrote:

Hi, @vivekmenezes https://github.com/vivekmenezes i will work on this

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cockroachdb/cockroach/issues/6101#issuecomment-217691152

@vivekmenezes I have opened the PR in https://github.com/cockroachdb/cockroach/pull/6666

Wow you got a lucky number. Ill take a look tonight

On Sat, May 14, 2016, 11:04 AM Thanakom sangnetra [email protected]
wrote:

@vivekmenezes https://github.com/vivekmenezes I have opened the PR in

6666 https://github.com/cockroachdb/cockroach/pull/6666

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cockroachdb/cockroach/issues/6101#issuecomment-219225114

Great job @prideloki :)
LGTM! But I only get to state my opinion!

Was this page helpful?
0 / 5 - 0 ratings