Cockatrice: the default tablezone tablezone.jpg, all players is not being honored in multiplayer (spectating)

Created on 16 May 2020  路  3Comments  路  Source: Cockatrice/Cockatrice

existing themes broken https://github.com/Cockatrice/Cockatrice/pull/3990
according to the PR i think the behavior should be
tablezone.jpg | default, all players
tablezone0.jpg | ignored
tablezone1.jpg | Player 1
tablezone2.jpg | Player 2
tablezone3.jpg | Player 3
?

* Edit - the screenshots below are while spectating games

1.
However the default tablezone tablezone.jpg | default, all players is not being honored.
the existing themes at https://github.com/Cockatrice/Cockatrice/wiki/Themes are broken in multiplayer Kitchen Table - by Yami | Screenshots
image



  1. Aalso, i created a grey bg and made the following copies:
tablezone.png
tablezone0.png  
tablezone1.png  
tablezone2.png 
tablezone3.png  
tablezone4.png  

And in a 3-player game the grey bg is not used for one of the tablezones and it purple when it should be grey.
image

Bug

Most helpful comment

No worries @fdipilla :)


according to the PR i think the behavior should be
tablezone.jpg | default, all players
tablezone0.jpg | ignored
tablezone1.jpg | Player 1
tablezone2.jpg | Player 2
tablezone3.jpg | Player 3

@jonschoning this should not be how it currently works, this provided table by @fdipilla was a suggestion for a potential ideal behavior, which is not yet implemented.

All 3 comments

Well, this is awkward. When testing I always replaced the default tablezone for a purple one so the change will be more obvious to me when in fact in doing so I was screwing up my tests. I'm so sorry for that, I feel like an idiot.

I think I got number 1 fixed now.
I'll be trying to replicate number 2.

Heh things happen, and that's why we beta test. Don't worry about it, @fdipilla :)

When you have a fix ready, feel free to open another PR!

No worries @fdipilla :)


according to the PR i think the behavior should be
tablezone.jpg | default, all players
tablezone0.jpg | ignored
tablezone1.jpg | Player 1
tablezone2.jpg | Player 2
tablezone3.jpg | Player 3

@jonschoning this should not be how it currently works, this provided table by @fdipilla was a suggestion for a potential ideal behavior, which is not yet implemented.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Thunderbeliever picture Thunderbeliever  路  6Comments

shackra picture shackra  路  4Comments

Assassinsquid picture Assassinsquid  路  4Comments

ShrewMaster picture ShrewMaster  路  6Comments

Gibidinp picture Gibidinp  路  7Comments