Cms: Cmd + S shortcut should handle another entry being created from an entry better

[architchandra]

Description

Cmd + S is extremely helpful when working on Craft, but if there is an Entries field being used and a new entry is created from within an entry (original entry), Cmd + S does not wait for the new entry to be created or ensure that it is saved.

It only saves the original entry while leaving the new entry unsaved and thus lost. It leads to needless headaches and repetition of work.

Steps to reproduce

1. Set up a Craft site with multiple entries and an Entries field assigned to the entry type
2. Edit an entry and click on 'Add an entry'
3. Instead of selecting an existing entry, create a new entry (as highlighted in the screenshot)
4. Enter some data for the new entry but do not save it
5. Press Cmd + S

Additional info

• Craft version: 3.4.13
• PHP version: 7.2.23
• Database driver & version: mysql Ver 14.14 Distrib 5.7.28, for macos10.14 (x86_64) using EditLine wrapper

[brandonkelly]

Just fixed this for the next release (3.4.16). Going forward, when the Ctrl/Command + S save shortcut is used and an element editor HUD is open, it will save the element editor HUD instead of the main entry. (And the shortcut will be completely ignored if any other HUDs/modals/menus are currently open).

[brandonkelly]

Craft 3.4.16 is out now with this change.