Cmder: Small issue with syntax highlighting in directories with "%20" in their name

Created on 20 Feb 2017 · 20Comments · Source: cmderdev/cmder

Any folder with %20 in the name gives the following error D:\cmder\vendor/clink.lua:42: invalid capture index and the syntax highlighting is broken.

Bug

Source

bancey

Most helpful comment

I added the following functions and replaces all string.gsub by replace:

function explode(separator, str, withpattern)
    if ( withpattern == nil ) then withpattern = false end
    local ret = {}
    local current_pos = 1
    for i = 1, string.len( str ) do
        local start_pos, end_pos = string.find( str, separator, current_pos, not withpattern )
        if ( not start_pos ) then break end
        ret[ i ] = string.sub( str, current_pos, start_pos - 1 )
        current_pos = end_pos + 1
    end
    ret[ #ret + 1 ] = string.sub( str, current_pos )
    return ret
end

function replace( str, tofind, toreplace )
    local tbl = explode( tofind, str )
    if ( tbl[ 1 ] ) then return table.concat( tbl, toreplace ) end
    return str
end

the functions are from https://github.com/garrynewman/garrysmod/blob/master/garrysmod/lua/includes/extensions/string.lua, which have no license attached :-(

jankatins on 21 Feb 2017

👍4

All 20 comments

Seems to be this:
http://stackoverflow.com/questions/11008520/putting-in-string-gsub-in-lua

I tried a few ways to escape it, but I wasn't successfull :-/

jankatins on 20 Feb 2017

Ahh that would also explain an issue I'm having with ^. If you try to apply a stash like so git stash apply stash^{/ExampleStash} you get a fatal error. I assume it's a similar issue being that ^ is an operator in lua?

bancey on 21 Feb 2017

I added the following functions and replaces all string.gsub by replace:

function explode(separator, str, withpattern)
    if ( withpattern == nil ) then withpattern = false end
    local ret = {}
    local current_pos = 1
    for i = 1, string.len( str ) do
        local start_pos, end_pos = string.find( str, separator, current_pos, not withpattern )
        if ( not start_pos ) then break end
        ret[ i ] = string.sub( str, current_pos, start_pos - 1 )
        current_pos = end_pos + 1
    end
    ret[ #ret + 1 ] = string.sub( str, current_pos )
    return ret
end

function replace( str, tofind, toreplace )
    local tbl = explode( tofind, str )
    if ( tbl[ 1 ] ) then return table.concat( tbl, toreplace ) end
    return str
end

the functions are from https://github.com/garrynewman/garrysmod/blob/master/garrysmod/lua/includes/extensions/string.lua, which have no license attached :-(

jankatins on 21 Feb 2017

👍4

want to make a PR?

Stanzilla on 22 Feb 2017

Do you want the functions which are upstream without a license?

jankatins on 11 Mar 2017

I think it's ok, it's pretty generic.. cc @MartiUK though

Stanzilla on 12 Mar 2017

I'd give a cautious yes to go ahead, a simple attribution in a comment would be enough I feel.

MartiUK on 13 Mar 2017

I'm not anymore using windows, and so also do not use cmder, so I cannot do this PR anymore :-(

jankatins on 11 Feb 2018

Has there been any movement on this issue?

jkesselring on 17 May 2018

conemu64_2018-05-17_15-09-39
Can't repo :(

Stanzilla on 17 May 2018

I see this is closed, but I want to throw this into the ring. In my case I'm using an SVN(I know) repo, perhaps that's the trick? Running CMDER v1.3.5 (Updated to v1.3.6 and issue persists).