Cluster-api: Switch KCP to use ClusterCacheTracker.GetClient for the workload cluster client

Created on 5 Aug 2020  Â·  12Comments  Â·  Source: kubernetes-sigs/cluster-api

Now that we have remote.ClusterCacheTracker, we should be able to use it to get a client for KCP to use for the workload cluster, instead of creating one - https://github.com/kubernetes-sigs/cluster-api/blob/7c8bb5e75f65d1f2376e20df8a965a166183bff7/controlplane/kubeadm/internal/cluster.go#L100-L103. See https://github.com/kubernetes-sigs/cluster-api/blob/7c8bb5e75f65d1f2376e20df8a965a166183bff7/controllers/machine_controller.go#L435 for an example of getting a client.

/area control-plane
/kind cleanup
/priority important-longterm
/milestone v0.4.0

arecontrol-plane help wanted kincleanup lifecyclactive prioritimportant-longterm

All 12 comments

/help

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wfernandes , I would love to help here, this seems to me a good first issue, could you please assign this to me ?

/assign pulkitmehra
/lifecycle active

@pulkitmehra Are you still working on this issue?

@vincepri I apologize for being late on this, when is the deadline for this issue? I can get this in by 20th Oct?

No rush, take your time!

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/lifecycle frozen

Hi @pulkitmehra! If you are not working on this, I can take this up.

/cc @vincepri

Sure- sorry for not completing this task.

On Jan 5, 2021, at 1:13 PM, Furkat Gofurov notifications@github.com wrote:


Hi @pulkitmehra! If you are not working on this, I can take this up.

/cc @vincepri

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

/assign
/lifecycle active

Was this page helpful?
0 / 5 - 0 ratings