Cluster-api: Set User Agent and Request Timeout for Remote Cluster Caches

Created on 1 May 2020  路  12Comments  路  Source: kubernetes-sigs/cluster-api

User Story

We should set a user agent on the clients used by the remote cluster caches introduced in #2880 so that request logs can be tracked back to the cluster caches.

We should also set a Timeout on the requests so that failed connections time out rather than hanging

(Originally suggested by @fabriziopandini and @ncdc)

/kind feature

help wanted kinfeature lifecyclactive prioritimportant-longterm

All 12 comments

/milestone v0.3.x
/help
/priority important-longterm

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/milestone v0.3.x
/help
/priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign
/lifecycle active

/milestone v0.4.0

/assign @evalsocket

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

/lifecycle frozen

/assign @nader-ziada

/lifecycle active

I think I need a little bit more context, can't find any previous conversations about this, is it just adding the user agent and timeout to the remote cluster client?

Yes, it is just that.
The user agent can be helpful when auditing API server calls
The timeout helps to avoid being blocked (by default the client waits forever)

Was this page helpful?
0 / 5 - 0 ratings