Cluster-api: Make clusterctl cert-manager timeout configurable

Created on 30 Mar 2020  路  9Comments  路  Source: kubernetes-sigs/cluster-api

User Story

As a developer using the clusterctl library, I would like to be able to specify a custom timeout for waiting for cert-manager to be available, as the default hard-coded 10 minute value might not be enough if my internet connection is slow.

As a user using clusterctl, I would like to be able to specify a custom timeout for waiting for cert-manager to be available, as the default hard-coded 10 minute value might not be enough if my internet connection is slow.

Detailed Description

See user story

Anything else you would like to add:

N/A

/kind feature

areclusterctl help wanted prioritimportant-soon

All 9 comments

/help
/milestone v0.3.4

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/milestone v0.3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/priority important-soon

@fabriziopandini How do we set other timeouts today? Environment variables, flags?

MVP for me is library-only for an API consumer. Bonus is a flag or env var.

/assign

The simplest implementation will be using envvars, like e.g we are doing for the overrideFolder.
Library only requires an interface change, soI highly raccomand to tackle this with https://github.com/kubernetes-sigs/cluster-api/pull/2597 and https://github.com/kubernetes-sigs/cluster-api/issues/2659

@fabriziopandini I was trying to implement this by adding a flag to the init command, do you think that is better or doing a env var?

Ok, env var is fine for now 馃槃

Was this page helpful?
0 / 5 - 0 ratings