Cluster-api: Add liveness and readiness probes
User Story
As a developer/user/operator I would like to have liveness and readiness probes for the Cluster API manager so that I am better informed when it is operational and ready to receive requests.
Detailed Description
See user story.
Anything else you would like to add:
It would be ideal if the readiness probe could only return true once the webhook server is online and ready to receive requests. I'm not sure how feasible this is, though.
/kind feature
/milestone v0.3.0
/priority important-soon
/help
ncdc
All 8 comments
@ncdc:
This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
User Story
As a developer/user/operator I would like to have liveness and readiness probes for the Cluster API manager so that I am better informed when it is operational and ready to receive requests.
Detailed Description
See user story.
Anything else you would like to add:
It would be ideal if the readiness probe could only return true once the webhook server is online and ready to receive requests. I'm not sure how feasible this is, though.
/kind feature
/milestone v0.3.0
/priority important-soon
/help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 6 Dec 2019
@ncdc I would like to work on this if possible
prankul88
on 12 Dec 2019
/assign @prankul88
vincepri
on 12 Dec 2019
/cc
chuckha
on 12 Dec 2019
This will be important for the e2e tests. I pretty much have to resort to retrying my creates until the webhook services are ready to respond. Would be happy to work with you @prankul88 if you'd like, feel free to reach out on slack or here. No obligation though, if you'd like to tackle it yourself that works for me too.
chuckha
on 12 Dec 2019
Note, whatever we don't won't be 100% accurate and may still flake because the goroutine our readiness checks run in is different from the goroutine for the webhook server. See https://github.com/kubernetes-sigs/controller-runtime/issues/723 for more details.
ncdc
on 12 Dec 2019
@chuckha Thanks. Would love your help. Give me some time to have a little more knowledge about it. Will reach out to you:)
prankul88
on 13 Dec 2019
There is work in progress for CAPA here: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/1487/. We should be consistent.
ncdc
on 22 Jan 2020
Related issues
chuckha
路
4Comments
alexeldeib
路
4Comments
mboersma
路
5Comments
vincepri
路
5Comments
oneilcin
路
6Comments
Most helpful comment
Note, whatever we don't won't be 100% accurate and may still flake because the goroutine our readiness checks run in is different from the goroutine for the webhook server. See https://github.com/kubernetes-sigs/controller-runtime/issues/723 for more details.