Cluster-api: Categorize events to distinguish between create/delete events

[harishspqr]

User Story
Currently the machine events does not indicate if they were related to create/delete of a Machine.
We need more metadata about the event to distinguish between create and delete events.
Detailed Description

Anything else you would like to add:

/kind feature

[vincepri]

/milestone v0.3.0
/priority important-longterm
/help

[k8s-ci-robot]

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/milestone v0.3.0
/priority important-longterm
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[noamran]

/assign

[ncdc]

@noamran do you have an approach in mind for this?

[noamran]

@noamran do you have an approach in mind for this?

@ncdc not yet. Is there a specific approach you think I should be taking?

[ncdc]

We currently use .Eventf to record events. There is also .AnnotatedEventf, which would allow us to set annotations on the events when we create them. I think that's one possible approach (define a key and values indicating create vs delete)

[ncdc]

After talking to @yastij yesterday, it sounds like a newer events API is going to remove the annotation support. The recommended path forward is to use conditions instead of events. xref #1658

[ncdc]

Going through open unassigned issues in the v0.3.0 milestone. We have a decent amount of work left to do on features (control plane, clusterctl, etc). I think we need to defer it to v0.4.

/milestone Next

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[vincepri]

Going to close this one for now, and merge the requirement in the conditions proposal coming up.

cc @fabriziopandini
/close

[k8s-ci-robot]

@vincepri: Closing this issue.

In response to this:

Going to close this one for now, and merge the requirement in the conditions proposal coming up.

cc @fabriziopandini
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.