Cluster-api-provider-azure: Add Services unit tests

[CecileRobertMichon]

This is an easy one because the ground work is already done, just needs iteration :)

Following examples in https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/cloud/services/virtualnetworks/virtualnetworks_test.go and https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/cloud/services/virtualmachines/virtualmachines_test.go, we should add a unit test suite for the other services/ packages.

• [x] (@noamran) availabilityzones
• [x] (@cpanato) disks
• [x] (@cpanato) groups
• [x] (@noamran) internalloadbalancers
• [x] (@asatish) networkinterfaces
• [x] (@cpanato) publicips
• [x] (@cpanato) publicloadbalancers
• [x] (@cpanato) routetables
• [x] (@nader-ziada) securitygroups
• [x] (@nader-ziada) subnets
• [x] (@cpanato) virtualmachineextensions
• [x] virtualmachines ~(partially done)~
• [x] virtualnetworks

/help

[CecileRobertMichon]

@noamran is going to look into availabilityzones and internalloadbalancers

[nader-ziada]

i'll take the securitygroups and subnets as a start

[asatish]

I can help with networkinterfaces and publicips

[cpanato]

@CecileRobertMichon can i try publicloadbalancers ?

[justaugustus]

@cpanato -- Go for it! :)

[cpanato]

@asatish are you working in the publicips tests?

[cpanato]

@CecileRobertMichon i will try disks as well

[asatish]

@asatish are you working in the publicips tests?

you can take it if you like, since I haven't got to it so far. Thanks..

[cpanato]

will take care groups

[cpanato]

will take care routetables

[cpanato]

will take care virtualmachineextensions

[cpanato]

Will check what is missing for virtualmachines

[cpanato]

@asatish are you working in the networkinterfaces tests?

[CecileRobertMichon]

@asatish any updates on network interfaces?

[cpanato]

@asatish @CecileRobertMichon I can work on that if you don't have time

[asatish]

Hi Carlos, sure you can go ahead and work on that, I haven't gotten to this
as yet.

Thanks,
Satish

On Thu, Mar 5, 2020 at 10:06 PM Carlos Tadeu Panato Junior <
[email protected]> wrote:

@asatish https://github.com/asatish @CecileRobertMichon
https://github.com/CecileRobertMichon I can work on that if you don't
have time

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/359?email_source=notifications&email_token=ABEN5YWF4UQN6DTO3WDA3LTRGCHFTA5CNFSM4KFAHZAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOAF7PA#issuecomment-595615676,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEN5YTRSOGJ3DUND2NVKJ3RGCHFTANCNFSM4KFAHZAA
.

[cpanato]

/remove-help