Cluster-api-provider-aws: Our awserrors.IsNotFound() doesn't work for at least ec2 instances

Created on 10 Dec 2019 · 9Comments · Source: kubernetes-sigs/cluster-api-provider-aws

/kind bug

What steps did you take and what happened:
If you terminate an ec2 instance out of band (manually i.e. CAPA didn't do it) and wait long enough such that the instance is no longer returned by a DescribeInstances call, this logic does not work correctly:

https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/e19e0e50ada52312f7c1b5decc761e0700f17d5b/pkg/cloud/services/ec2/instances.go#L89-L92

The error returned by ec2 looks like this:

InvalidInstanceID.NotFound: The instance ID 'i-xxxxxxxxxxxxx' does not exist
    status code: 400, request id: ...

Note the status code is 400. Our awserrors.IsNotFound() has this:

https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/e19e0e50ada52312f7c1b5decc761e0700f17d5b/pkg/cloud/awserrors/errors.go#L105-L111

We don't match on http.StatusNotFound (400 != 404). And IsInvalidNotFoundError does this:

https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/e19e0e50ada52312f7c1b5decc761e0700f17d5b/pkg/cloud/awserrors/errors.go#L124-L133

We probably need to also check for InvalidInstanceID.NotFound

What did you expect to happen:
The InstanceIfExists call should return nil, nil in this scenario.

Environment:

Cluster-api-provider-aws version: v0.4.7 & master

good first issue help wanted kinbug lifecyclactive prioritimportant-soon

Source

ncdc

All 9 comments

Or maybe we need to do a regex match on ^Invalid[^.]+\.NotFound$?

ncdc on 10 Dec 2019

I'd just add another case for now, unless you prefer the regex thing

vincepri on 10 Dec 2019

/help
/good-first-issue
/milestone v0.5.0

ncdc on 16 Dec 2019

@ncdc:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue
/milestone v0.5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.