There is an Elasticsearch client leak in the Elasticsearch driver:
In most cases the client created for the observer is never closed, leading to a memory leak.
I wonder if this would suffice as a fix:
diff --git a/pkg/controller/elasticsearch/observer/manager.go b/pkg/controller/elasticsearch/observer/manager.go
index 29dc54ea..2921e048 100644
--- a/pkg/controller/elasticsearch/observer/manager.go
+++ b/pkg/controller/elasticsearch/observer/manager.go
@@ -49,6 +49,7 @@ func (m *Manager) Observe(cluster types.NamespacedName, esClient client.Client)
m.StopObserving(cluster)
return m.createObserver(cluster, esClient)
default:
+ esClient.Close()
return observer
}
}
Most helpful comment
I wonder if this would suffice as a fix: