I think the current doc could be improved. JVM heap size and memory requirements documentation is spread over 3 different pages:
JAVA_OPTS environment variable and resource reqs but does not provide any example.I think we also want to make it clear that we recommend setting memory requests and limits to twice the JVM heap size.
After discussion with @sebgl:
https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-pod-template.html:
Keep it and replace the latest example (related to JVM heap size) with a different example
https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-jvm-heap-size.html:
remove it as it duplicates content already available on https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-managing-compute-resources.html
(before removing, make sure all the info is maintained in Managing compute resources)
@sebgl can you please provide an appropriate example for https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-pod-template.html?
@sebgl can you please provide an appropriate example for https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-pod-template.html?
Looking at it I think it is fine to just remove this example. The other example and the links to the Kubernetes documentation seem enough to me.
I was thinking of suggesting that we move the pod template document out of the Elasticsearch section because pod templates are applicable to Kibana and APM Server as well. We should probably provide an example each because the location of podTemplate in the manifest is different. I have a draft document ready and will create a PR shortly.
Further discussing with @charith-elastic:
Let's reconsider the https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-jvm-heap-size.html removal when we get to a more global reorg of the Run Elasticsearch on ECK section.
Also, IMO, setting the heap size is a common thing that most users want to do (and probably search for in a search engine) so having a section titled "JVM heap size" might be better for ease of discovery. It simply points users to the "Managing compute resources" section so there's no danger of content duplication either.
This issue might be closed in favour of #2673, where the section https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-jvm-heap-size.html will be part of a general reorganisation of the topics currently under Run Elastic on ECK.
@sebgl and @charith-elastic what do you think?
Close in favour of #2673.
Most helpful comment
This issue might be closed in favour of #2673, where the section https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-jvm-heap-size.html will be part of a general reorganisation of the topics currently under Run Elastic on ECK.
@sebgl and @charith-elastic what do you think?