Closure-compiler: buildRegistry in ModuleLoader doesn't handle case of immediate node_modules

Created on 24 Nov 2016  Â·  5Comments  Â·  Source: google/closure-compiler

E.g. if an input is node_modules/left-pad/index.js that never hits the split for /node_modules/ and thus isn't subject to the resolve algorithm.

CC @ChadKillingsworth

Most helpful comment

That PR is the culmination of a year's work.

All 5 comments

Thanks. I hadn't seen this case because the grunt and gulp plugins don't use file paths like that.

The fix for this is part of #2130

Nice, also fixes my next feature request :)

On Tue, Nov 29, 2016 at 11:02 AM, Chad Killingsworth <
[email protected]> wrote:

The fix for this is part of #2130
https://github.com/google/closure-compiler/pull/2130

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/closure-compiler/issues/2170#issuecomment-263665201,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFeT6k9VR6Y8poCl20TPv_kpbwZf8FQks5rDHbUgaJpZM4K7U4K
.

That PR is the culmination of a year's work.

Closed by #2130

Was this page helpful?
0 / 5 - 0 ratings

Related issues

zzo picture zzo  Â·  6Comments

JohannBlake picture JohannBlake  Â·  3Comments

ChadKillingsworth picture ChadKillingsworth  Â·  5Comments

jart picture jart  Â·  7Comments

ChadKillingsworth picture ChadKillingsworth  Â·  7Comments