Client: owncloud desktop client tray icon difficult to see

[thoja21]

Possibly related to changes made for issue #7356

Expected behaviour

Icon should appear white, or coloured (as before in version 2.6.3).

Actual behaviour

Icon is now dark blue in colour (almost invisible in tray). Toggling monochrome icons only changes the sync status part of the icon. See attached screenshot of icon in Windows status icon tray:

Steps to reproduce

1. Open ownCloud desktop client on Windows 10.
2. Check ownCloud icon.

Client configuration

Client version: 2.7.1

Operating system: Windows 10 version 2004

OS language: English (United Kingdom)

Installation path of client: default (Program files)

[thejungletiger]

I am also experiencing this issue. Windows 10 Pro 20H2 Build 19042.630, OwnCloud client 2.7.1 Build 2560. Prior to the update I was using the colorized icons. Turning on monochrome icons just hides the entire icon as seen above. Changing to light mode for Windows leaves the dark icon (visible of course).

[h4rp00n33r]

Same experience here (Windows 10 Pro 20H2 Build 19042.630, OwnCloud client 2.7.1 Build 2560):

[sagamusix]

Same here. In general I use the light Windows 10 theme, but with a dark taskbar (as it was default until some recent Windows 10 update, 1909 or 2004?). I suppose the client now simply checks if the light theme is used, instead of whether a light taskbar is used?

[mutipg]

I'm confirming this issue too. Dark theme Windows 10.

[TheOneRing]

Yes we are only checking UIColorType_Background so if the dark theme has a light taskbar ... meh, will need more research.
Also be aware that the icon will not instantaneously be updated, clicking around on the ui might get you an updated icon.

[thejungletiger]

My system is a dark theme with a dark taskbar, so that does not apply. I also have not changed my theme at all vs the software updating and instantly losing the proper icons.

[TheOneRing]

[h4rp00n33r]

Yes, it works correct as long as you choose "pure" themes "dark" or "light". But in this mixed mode (dark windows mode, light app mode) it's broken:

[thejungletiger]

That's how it should work. But not how it is working.

As above, seems to work when the same, but not mixed.

[TheOneRing]

Ouch, so again we learn: don't trust stackoverflow 🙈

[sagamusix]

If it's impossible to query the correct value, I wonder if a little outline for the icon would help?

[TheOneRing]

Looks like rather than using some complex winrt code we just need to check
HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Themes\Personalize\SystemUsesLightTheme

[sagamusix]

Keep in mind that having separate system and app themes is a relatively new feature in Windows 10, though (as said, I think it was introduced in 1909 or 2004). If the registry key doesn't exist, you should probably fall back to assuming that the taskbar is dark.

[TheOneRing]

I see 2.7.2 on the horizon

[h4rp00n33r]

Now everything works perfect again. Thanks, @TheOneRing