Client: Client 2.6.0 has some English text though used language is German

[lazawan]

Hi there ,

i just noticed that ownCloud-Client 2.6.0daily20190514 (build 11739) has some words in English though used language is German

please see the screenshots below :

regards

[mtx500]

At least for the text in the first picture (in src/gui/folderstatusmodel.cpp), there is no entry in Transifex. So there are no translations available at all.

[guruz]

src/gui/folderstatusmodel.cpp:            ? QStringList(tr("Virtual file support is enabled."))

If you don't see it in transifex, maybe @dschmidt needs to change the branch used in transifex.

[guruz]

I think @dschmidt fixed transifex by now, can you re-check?

[guruz]

@michaelstingl @tboerger @DeepDiver1975 @dschmidt Please please fix translations for 2.6 branch. Last updated 3 months ago :-(
https://github.com/owncloud/client/tree/2.6/translations

[guruz]

@dschmidt That's the subdirectory not the branch ;-)

[dschmidt]

Noticed, that's why I removed my comment - I'm checking what's wrong.

[dschmidt]

Urghs: https://drone.owncloud.com/owncloud/translation-sync/687/335

[guruz]

Same for me locally.

guruz@mgmbp2018 translations $ make l10n-read
cd .. && lupdate src -no-obsolete -ts translations/client_en.ts
Scanning directory 'src'...
/Users/guruz/woboq/owncloud/client/mirall/src/3rdparty/libcrashreporter-qt/3rdparty/breakpad/common/mac/macho_reader.cc:418: Ignoring definition of undeclared qualified class
/Users/guruz/woboq/owncloud/client/mirall/src/3rdparty/libcrashreporter-qt/3rdparty/breakpad/common/mac/macho_reader.cc:513: Ignoring definition of undeclared qualified class
/Users/guruz/woboq/owncloud/client/mirall/src/gui/shareusergroupwidget.cpp:449: Unterminated C++ string
/Users/guruz/woboq/owncloud/client/mirall/src/gui/shareusergroupwidget.cpp:456: Unterminated C++ string
/Users/guruz/woboq/owncloud/client/mirall/src/gui/shareusergroupwidget.cpp:627: Excess closing brace in C++ code (or abuse of the C++ preprocessor)
/Users/guruz/woboq/owncloud/client/mirall/src/libsync/propagatedownload.cpp:185: Qualifying with unknown namespace/class ::GETFileJob
/Users/guruz/woboq/owncloud/client/mirall/src/libsync/syncengine.cpp:350: Qualifying with unknown namespace/class ::OCC
Updating 'translations/client_en.ts'...
    Found 840 source text(s) (125 new and 715 already existing)
    Removed 89 obsolete entries

[guruz]

But still it changed the file, those messages are just warnings(?): modified: client_en.ts

[guruz]

Ah but you are getting:

lupdate warning: For some reason, 'translations/client_en.ts' is not writable.

I think it's odd that make l10n-read is run in the source directory, not shadow build directory.

[dschmidt]

Yes, that's the point. Running in source tree is fine, we actually want to change the files in the source tree. Also there's a handwritten Makefile there, it's not related to CMake in any way. The issue is probably that the files belong to root and lupdate is run as a user, because the docker image I'm using is setting a default user other than root. I tried to add a workaround, let's see...

[guruz]

we actually want to change the files in the source tree.

We could get cmake to copy the translations to build directory though and use them from there.. just an idea.

But your docker hotfix sounds easier

[guruz]

Ah you're right because we need to commit back to source directory. OK ignore my comment please.

[tboerger]

Unassigned myself as @dschmidt is already working on it.

[HanaGemela]

Retested with daily MacOS build 2.6.0-daily20190613 (build 11917) and it still uses English when speaking about virtual files

[ckamm]

It looks like the updated translations have not yet arrived in our repo.

[jnweiger]

Tested In branches master and 2.6

We still have

grep -C2 'support is enabled' translations/client_en.ts 
    <message>
        <location filename="../src/gui/folderstatusmodel.cpp" line="215"/>
        <source>Virtual file support is enabled.</source>
        <translation type="unfinished"></translation>
    </message>

Although we have it in transifex like this:

[ckamm]

@jnweiger The translations should be there now, I see them in client_de.ts.

[jnweiger]

@ckamm yeah, I can see them in 2.6 branch! How about also keeping master up to date? https://github.com/owncloud/translation-sync/pull/19

[ckamm]

@jnweiger We sometimes merge 2.6 to master, keeping it up to date.