Client: reproducible data loss when file is renamed and virtual file suffix is added at the same time

[lazawan]

Hi there ,

operating system : Ubuntu 18.10; client 2.5.2rc2

i think title says a lot , simply follow the steps to reproduce the data loss :

• enable virtual-files Feature
• delete all files in sync-folder then a message pops up ,please select keep files
• let's suppose we have 2 files with following extensions :
  something.txt.owncloud_virtual
  something.pdf.owncloud_virtual
• please download the files (listed above) over owncloud-menu
• files are now so : something.pdf and something.txt
  -now rename files to something.owncloud_virutal (please delete the extensions .pdf and .txt )
• force sync
  -files are not existing any more on the server

regards

[jnweiger]

Also reproducable with a windows client. Ouch!

[lazawan]

reproducible with Macos client as well , i have just tested it

[ckamm]

Yes, simpler reproduction:

• have test.txt synced
• rename to other.txt.owncloud
  test.txt will be deleted and other.txt.owncloud will be ignored.

The sync engine sees this as a deletion of test.txt and the creation of an erroneous placeholder file other.txt.owncloud.

What's the expected behavior? Renaming test.txt to other.txt on the remote and dehydrating other.txt.owncloud?

I expect a similar problem to occur if one renamed test.txt.owncloud to other.txt: test.txt.owncloud would be recreated and a silly other.txt would be uploaded.

[guruz]

(Issue moved per @ckamm internal comment)

[ckamm]

Reasons: This is complicated to fix. A fix would take a bit and probably not be in time for 2.5.3. Also, a fix in 2.5 would need to be redone against the new discovery code in 2.6, doubling the work. I think moving to 2.6 is acceptable since the feature is experimental.

[lazawan]

@ckamm unfortunately it's still reproducible with ownCloud-2.6.0.11958.11762-daily20190510.msi

[ckamm]

@lazawan On Windows with cfapi based vfs .owncloud files should have no special behavior at all. What exactly are you seeing?

[lazawan]

@ckamm i added extension .ownCloud to a virtual file (a pdf file in virtual mode with Cloud sign ) and then this file was ignored from client and disappeared from server

[ckamm]

Interesting, looks like .owncloud is in the ignore list? I'll try to reproduce.

[lazawan]

@ckamm i have just checked the ignore list , .ownCloud ist not in the list
and i could reproduce it again :'(

[ckamm]

@lazawan I've not been able to reproduce the problem with ownCloud-2.6.0.12048.11850-daily20190530.msi. When I rename to .ownCloud in my wincfapi vfs folder the rename gets propagated to the server.

The behavior you describe would happen for ignored files. Could you double check your C:\Users\$USER\AppData\Roaming\ownCloud\sync-exclude.lst? Some in-between test versions when we started working on vfs added the .ownCloud extension there.

If it's not there: could you get me some logs?

[HanaGemela]

macOS 10.14.5, 2.6.0alpha2 (build 12128)

Scenario 1

1. have test.txt synced
2. rename to other.txt.owncloud
   Actual result: This keeps only one file -> OK

Scenario 2

1. have virtual file test.txt.owncloud
2. rename to other.txt
   Actual result: This keeps both copies -> Not OK

[ckamm]

I can reproduce the issue in scenario 2 - which is odd because there's an explicit autotest for it and that passes.

[HanaGemela]

Works as expected on macOS 10.14.6, client 2.6.0beta1 (build 12241)