Client: Adapt "public link" permissions to oC server 10.0.4 UI

[michaelstingl]

UI for "public link" permissions has been improved with oC server 10.0.4:
https://github.com/owncloud/core/pull/29376

@ckamm What is the effort to bring this to the desktop client? /cc @guruz @ogoffart @SamuAlfageme

[ogoffart]

I don't think it is too difficult. But this would still be something we would only do in 2.5, right? (because otherwise it would delay the 2.4 release)

(I'm wondering if it would not be better to open the browser to share instead of having a native dialog, that way we always have the same ui. (but that would need a decent single sign on mechanism))

[SamuAlfageme]

@ogoffart 👍 for 2.5, no need to rush this over 2.4

(I'm wondering if it would not be better to open the browser to share instead of having a native dialog, that way we always have the same ui.

I wonder the same; see comments in https://github.com/owncloud/client/issues/5796 and https://github.com/owncloud/client/issues/5797. However, I like the minimalist approach of client's native sharing dialog and all @ckamm's nice redesigns for 2.4/2.5 (meaning I'd still keep it for straightforward tasks)

(but that would need a decent single sign on mechanism))

yup: https://github.com/owncloud/client/issues/633 was one of my main ideas for the upcoming ownCloud hackweek

[michaelstingl]

we would only do in 2.5, right?

yes

decent single sign on mechanism

==> next week 😉

[ckamm]

It's a minor change.

Fwiw, I'd be perfectly fine with replacing the native UI if we can make it work reliably and smoothly for the user.

[pmaier1]

Sorry to open this again but we refined the wording for the web interface and I would like to adapt this for the next client release as well:

• [ ] Download / View
  Recipients can view or download contents.
• [ ] Download / View / Upload
  Recipients can view, download, edit, delete and upload contents.
• [ ] Upload only (File Drop)
  Receive files from multiple recipients without revealing the contents of the folder.

[michaelstingl]

For comparison: This was planned for 2.5:

| oC server 10.0.4 | (was) planned for 2.5 |
| - | - |
| | |

[pmaier1]

@michaelstingl looks good, so only wording change :+1: Please don't call the headline "Link properties". Can we agree on just having Permissions?

[michaelstingl]

@pmaier1 Changing again is pain, but I also prefer the new wording for non-tech users.

@ckamm I'm very sorry, but could you do your magic once again for us? Thanks!

[ckamm]

It's a straightforward change, sure :)

[pmaier1]

Please don't call the headline "Link properties". Can we agree on just having Permissions?

(Or just remove the headline as there is none in the WebUI as well)

It's a straightforward change, sure :)

:+1:

[jnweiger]

Pretty accurate in 250beta1 with compared to the update from @pmaier1 above:

checked on win10 and ubuntu18 with nautilus