Client: 2.3.3 Missing context menu text

[pierrejochem]

Compiled by my own

Expected behaviour

See text "share via ..." in context menu

Actual behaviour

Context menu is there but without text string

Any ideas?

[SamuAlfageme]

@pierrejochem which version of windows are you using? How did you install the client? (i.e. clean installation, update...)

Have you, by any chance, installed the nightly 2.4 version of the client before 2.3.3? It could leave the newer shell integration binaries upon uninstall and cause inconsistency.

@jturcotte have you ever seen this one?

[jturcotte]

"Compiled by my own" is going to be the cause if you've been changing some cmake variables and the Theme class.

[pierrejochem]

Which one could cause this? I'm using a script since Version 1.8.0.0 for the compilation process. Without this trouble and without a modification :-| (but I do theming)

[pierrejochem]

The strange thing is that only the context menu is affected

[pierrejochem]

@SamuAlfageme Windows 10 Enterprise Version 1703 by the way

[jturcotte]

This is where it gets sent to the shell extension:

https://github.com/owncloud/client/blob/v2.3.3/src/gui/socketapi.cpp#L506

You might also run into issues if the shell extension DLL doesn't match the client version you're using (which is in the binary submodule).

[pierrejochem]

I will check this and also the appNameGUI() prop. Maybe that is a hint to the cause

[pierrejochem]

But there must be a change from Version 2.3.2 to 2.3.3. With 2.3.2 it works without problems

[jturcotte]

Maybe, but this is not a supported API. If you play with this you are responsible to fix regressions when rebasing to a newer version.

Feel free to pass by #owncloud-client-dev on freenode if you want to ask for help with customization, but this isn't an actual issue unless you can reproduce it with our official builds or source package build instructions.

[jturcotte]

One thing I know that changed is with 2.4, we now have a sub-menu and request strings a bit differently. So if you've been installing any nightly build, this might conflict with your 2.3 build trying to use the same shell extension binary.

[michaelstingl]

@haukman showed me the same behaviour today. Maybe he can show @SamuAlfageme whats going on…

[SamuAlfageme]

@haukman happy to take a look into your setup

[haukman]

@SamuAlfageme perfect, just ping me in rocket!

[pierrejochem]

@guruz: Do I understand it correct, that it will be fixed in Version 2.4.0?

[haukman]

@pierrejochem @SamuAlfageme: Works fine with 2.4alpha for me - I have two accounts configured and can see the context menu again! Thx!

[pierrejochem]

I have tried it with Version 2.4.0 alpha and I can see the context menu again too

[michaelstingl]

I also got feedback from a user, that it is fixed in the 2.4.0 alpha1