Client-go: Release v11.0.0

Created on 29 Mar 2019 · 21Comments · Source: kubernetes/client-go

Tracking issue for the v11.0.0 release. This release corresponds to Kubernetes release 1.14.

TODO:

[ ] Create the release notes spreadsheet.
[ ] Update CHANGELOG and README.
[x] Run smoke tests.
[x] Manually verify that all commits in the tag are correct and git checkout v11.0.0 && godep restore && go build ./... runs successfully.
[x] Create the tag/release.
[ ] Link the changelog on the releases page.
[x] Fix the tag title using GitHub UI

/assign
/cc @sttts

Source

nikhita

❤1

Most helpful comment

using v11.0 also gets the same error:

...\go\pkg\mod\k8s.io\client-go@v11.0.0+incompatible\rest\request.go:598:31: not enough arguments in call to watch.NewStreamWatcher
have (*versioned.Decoder)
want (watch.Decoder, watch.Reporter)

rsreeni on 28 Aug 2019

👍2

All 21 comments

for reference, smoke test for v10.0.0:
https://gist.github.com/nikhita/fcf466640d4d8a754cbb6f153a67e57b

nikhita on 29 Mar 2019

smoke test for v11.0.0: https://gist.github.com/nikhita/9f9806ccf14752fa436a7b23c5450423

nikhita on 3 Apr 2019

https://github.com/kubernetes/client-go/releases/tag/v11.0.0 has been released because we want to tag before moving to go modules for good.

changelog will be done as a follow up.

nikhita on 3 Apr 2019

I'm getting an error building 11 with 1.14.1 release modules.

../../Go/pkg/mod/k8s.io/[email protected]+incompatible/rest/request.go:598:31: not enough arguments in call to watch.NewStreamWatcher
    have (*versioned.Decoder)
    want (watch.Decoder, watch.Reporter)

Looks like a change hasn't been back ported to the release branch.

NeilW on 9 Apr 2019

Looks like a change hasn't been back ported to the release branch.

That is a change on master of apimachinery. Make sure you are using kubernetes-1.14.1 tags of k8s.io/apimachinery

liggitt on 9 Apr 2019

I am using 1.14.1 tags on all the kubernetes structure. Or at the very least I'm trying to

[ $# -eq 1 ] || { echo "Supply new version number" >&2; exit 1; }

go get k8s.io/kubernetes@v$1 \
    k8s.io/cloud-provider@kubernetes-$1\
    k8s.io/api@kubernetes-$1\
    k8s.io/apimachinery@kubernetes-$1\
    k8s.io/apiserver@kubernetes-$1\
    k8s.io/apiextensions-apiserver@kubernetes-$1\
    k8s.io/csi-api@kubernetes-$1\
    k8s.io/kube-controller-manager@kubernetes-$1 \
    k8s.io/client-go@kubernetes-$1

Has something new been introduced?

NeilW on 9 Apr 2019

Yup. It's 'k8s.io/component-base' that's the culprit.

Roll on modules...

Apologies for the noise.

NeilW on 9 Apr 2019

@nikhita , any updates on the changelog? Thanks!

tamalsaha on 21 Apr 2019

@nikhita is this complete?

liggitt on 2 Jul 2019

The release notes haven't been added yet. Currently, the way we write release notes for client-go is to generate a list of PRs that touch a set of staging repos, go through each of them and if the PR needs to have a release note, write it down manually.

I don't have time to do these manually anytime soon - especially this week. :(

The same would be need to be done for v12.0.0. I'd again prefer to release it and follow up with the release notes later as a help wanted issue for both releases (I am happy to generate the PR list, just don't have time to go through each of them).

Also, v12.0.0 is currently blocked by https://github.com/tools/godep/issues/535.

nikhita on 2 Jul 2019

Also, v12.0.0 is currently blocked by tools/godep#535.

why? we're not using godep any more with v1.15.0 / v12.0.0, right?

liggitt on 2 Jul 2019

Yes, sorry, not blocked. :)

nikhita on 2 Jul 2019

Recently, I'm trying to update client-go to a newer version but found that CHANGELOG hasn't been updated after v1.10. The Breaking Changes section of CHANGELOG is really helpful for us. Just wondering will CHANGELOG also get updated for release v1.11.0 & 1.12.0?
And thanks for the effort to maintain this repo.

life1347 on 17 Jul 2019

I'll take a look over this weekend :)

nikhita on 17 Jul 2019

😄1

Hi @nikhita, are there any updates for this issue?

life1347 on 22 Aug 2019

Hi,
I am stuck with the same error also.
/go/pkg/mod/k8s.io/[email protected]+incompatible/rest/request.go:598:31: not enough arguments in call to watch.NewStreamWatcher have (*versioned.Decoder) want (watch.Decoder, watch.Reporter)

I had used k8s.io/apimachinery v0.0.0-20190820100751-ac02f8882ef6 & k8s.io/client-go v0.0.0-20190425172711-65184652c889

I would appreciate any help/update on this.

Thanks,

-Sreeni

rsreeni on 28 Aug 2019

👍2

using v11.0 also gets the same error:

...\go\pkg\mod\k8s.io\client-go@v11.0.0+incompatible\rest\request.go:598:31: not enough arguments in call to watch.NewStreamWatcher
have (*versioned.Decoder)
want (watch.Decoder, watch.Reporter)

rsreeni on 28 Aug 2019

👍2

same error. and if i try to work around the issue by forcing the same version as i get with dep (v9.0.0):

```go get k8s.io/[email protected] (shared-be-1.k8s.local/tooling)
go: finding k8s.io v9.0.0
go: finding k8s.io/client-go v9.0.0
verifying k8s.io/[email protected]+incompatible: checksum mismatch
downloaded: h1:NXWpDuPFeVB5lYP1fTqJUtwigjtmRXJNtndnN53ldGI=
sum.golang.org: h1:2kqW3X2xQ9SbFvWZjGEHBLlWc1LG9JIJNXWkuqwdZ3A=

SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.
```

colindickson on 6 Sep 2019

v11.0.0 has been released: please close.

carnott-snap on 16 Sep 2019

/close

sttts on 16 Sep 2019

@sttts: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.