Client-go: "create-update-delete-deployment" example outdated

[rabenhorst]

The "create-update-delete-deployment" example seems to be outdated because
RollbackTo of v1beta1.DeploymentSpec is deprecated.

There example should be updated using Rollback of v1beta1.DeploymentExpansion.

[nulltrope]

@mactr0n good catch. I'll get that updated

[anubhakushwaha]

@sttts @jekohk I would like to work on this issue

[nulltrope]

@anubhakushwaha feel free to pick this up. Let me know if you have any questions but it should be pretty straightforward.

[nikhita]

apps/v1 deployments are GA so the example should be updated to it.

[nikhita]

@anubhakushwaha You can use https://github.com/kubernetes/kubernetes/pull/58446 as a reference.

https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.9/#deployment-v1-apps

[nikhita]

/help

[nikhita]

oops

/remove-help

since already assigned to @anubhakushwaha

[nikhita]

@anubhakushwaha When deployments are updated to use apps/v1, we should probably end up documenting this as well (see https://github.com/kubernetes/kubernetes/pull/59104).

[nulltrope]

Hi @anubhakushwaha
I believe you need to use the Rollback function from the DeploymentExpansion interface in extensions/v1beta1

[nikhita]

/assign @k8s-external-contributor

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[nikhita]

This is already done by @anubhakushwaha in https://github.com/kubernetes/kubernetes/pull/59970 🎉

Closing this issue. If you have comments about the rollback option using client-go, please comment in https://github.com/kubernetes/client-go/issues/398.

/close