Cli: Cannot Start New Project with Modules

[russoj88]

I'm trying to use this in a new project (using go modules), but am receiving the following error. I also tried updating an existing project, but it failed with a similar error. This is on PopOS 19.04 (Ubuntu 19.04), go 1.12.7.

main.go:

package main

import (
    "gopkg.in/urfave/cli.v1"
    "log"
    "os"
)

func main() {
    err := cli.NewApp().Run(os.Args)
    if err != nil {
        log.Fatal(err)
    }
}

# go get gopkg.in/urfave/cli.v1
go: gopkg.in/urfave/[email protected]: go.mod has non-....v1 module path "github.com/urfave/cli" at revision v1.21.0
go: error loading module requirements

This worked with cli 1.20.0.

[AudriusButkevicius]

You should use the github url, rather than gopkg.in. Whether that is right or not is debatable but it will address your issue.

[lynncyrin]

👍 for using the GitHub URL, I have no idea how the gopkg.in url works

[russoj88]

@AudriusButkevicius That does work, but like the documentation says, that'll cause issues when v2 becomes master.

This is the section I'm referring to: https://github.com/urfave/cli#pinning-to-the-v1-releases

[lynncyrin]

The readme is outdated, pinning github has nothing to do with v1 vs v2

[russoj88]

Got it. Mind if I make an issue for outdated docs?

[AudriusButkevicius]

A pr would be more welcome

[russoj88]

I'd like to do a pr as well, but I think it'd just be me asking someone here what to put in. If that's ok, I can start that now.

[lynncyrin]

@russoj88 yeah totally! go for it 👍