Cli: Add verbose logging to all commands

Created on 16 Jan 2019  路  14Comments  路  Source: react-native-community/cli

Add --verbose flag to enable DEBUG log level.
Logger unification and implementation is tracked in #95

feature request good first issue

All 14 comments

Is anyone working on this? If not, I'd like to give it a try 馃槃

@matei-radu afaik nobody works on this currently. Feel free to grab it! :)

Can we close this? it was done in #239 I believe.

It's been implemented but many commands of the CLI still don't have any debug level log messages.

Maybe we should track those as a list in a dedicated issue and close this 馃

@matt-block I second this :)

Who's willing to make a list of commands that have logger.debug calls and ones that don't? :)

@thymikee I can do that. Should I create a new issue for this?

Nah, let's add this list here and I can keep it updated :)

@thymikee what's the status of this?

Debug logging is still not present in every command. We need to compile a list and let people work on it

OK, so here's the list of commands, ones that have logger.debug calls are checked.

  • [x] start
  • [ ] bundle
  • [ ] ram-bundle
  • [x] link
  • [x] unlink
  • [ ] install
  • [ ] uninstall
  • [x] upgrade
  • [ ] info
  • [ ] config
  • [x] init
  • [ ] log-ios
  • [x] run-ios
  • [ ] log-android
  • [x] run-android

EDIT: as per @Esemesek comment below, stricken-through items are those that don't really need verbose logging

In addition to @maciejsimka list:

  • log-android and log-ios are using logkitty to log device logs. We don't need verbose logging there, because they are verbose by default.
  • info and config are very basic and verbose logging there isn't necessary
  • install and uninstall have verbose logging when linking happens - I think we don't need more logging there

are there any additional logging required for this issue?
the unchecked options are bundle and ram-bundle, which both leads to buildBundle which has loggings.

@Naturalclar it seems like this issue should be closed. C:

Was this page helpful?
0 / 5 - 0 ratings