Cli-microsoft365: New command: set knowledge hub site url

[appieschot]

Usage

spo knowledgehub set

Description

Sets the Knowledge Hub Site for your tenant

Options

| Option | Description |
| ----------------------- | ----------------------------------------- |
| -u, --url <url> | URL of the site to set as Knowledge Hub

Additional Information

Use same implementation as PnPPowershell: https://docs.microsoft.com/en-us/powershell/module/sharepoint-pnp/set-pnpknowledgehubsite?view=sharepoint-ps

[arjunumenon]

Hey @appieschot - Do you mind if I take this up?

[garrytrinder]

All yours @arjunumenon thanks for the help 👍🏻

[arjunumenon]

@garrytrinder / @appieschot Just now realized a typo. In the specs, the command was mentioned as knowledegehub while in actual, it should have been knowledgehub.

Do you think it make sense to update the command to be knowledgehub. If Yes, can you cancel / reject my PR so that I can submit updated changes. If that is the case, I think it is better to update the specs as well.

I am sorry I should have pointed that out before I implemented the code.

[garrytrinder]

Good catch @arjunumenon 👍🏻

I have updated the OP with the corrected command name.

No need to cancel the PR, you can push the new changes or we can pick up the change in the PR review.

[arjunumenon]

Thanks @garrytrinder for the advise. 👍. I will submit another PR.
Another question, pardon me if it is trivial. Do you want me to squash the commits into single when I submit the PR. Haven't come across that scenario before. Hence curious how to handle that.

[garrytrinder]

Its nice to get into the habit of squashing your commits, I blogged about how to do this using git interactive rebase, which might be helpful, https://garrytrinder.github.io/2020/03/squashing-commits-using-interactive-rebase however we like with the typo change we can pick this up in the PR review 👍

[arjunumenon]

Thanks @garrytrinder .I have already bookmarked your blog post which will be super useful. Thanks for that.

I will submit another PR with typo change comments when I do the PR. Thanks again for the guidance.