Cli-microsoft365: Bug report: Update componentType in .you-rc.json seems incorrect for an extension

Created on 12 May 2020  路  4Comments  路  Source: pnp/cli-microsoft365

Description

Run SPFx Upgrade command ( see attached report) on a forked copy React Application Regions Footer extension .

In Update componentType in .yo-rc.json:

{
  "@microsoft/generator-sharepoint": {
    "componentType": "webpart"
  }
}

However, given I this is a SPFx extension, the recommended compentType looks incorrect.

Steps to reproduce

spfx project upgrade --toVersion 1.10.0 --output md --outputFile "upgrade-report.md"

Expected result

The report should indicate:


{
  "@microsoft/generator-sharepoint": {
    "componentType": "extension"
  }
}

Actual result

See upgrade-report.zip

Environment

npm install -g @pnp/office365-cli@next
2.10.0-beta.4206056

bug work in progress

Most helpful comment

@waldekmastykarz Thanks for the update. I have some thoughts on some of the .vscode changes but will formulate these, outside this issue.

All 4 comments

Hey @westerdaled, thanks for reporting this. This doesn't seem right indeed. We'll get it fixed asap.

@waldekmastykarz Thanks for the update. I have some thoughts on some of the .vscode changes but will formulate these, outside this issue.

Awesome! Appreciate your help!

We have just release a new beta version with the fix. Once again, thank you for reporting it 馃憦

Was this page helpful?
0 / 5 - 0 ratings