Cli-microsoft365: Bug report: Failing tests

[rabwill]

Description

Two tests are failing for PA
1) TemplateInstantiator
creates structure for shared files at (74)
o365/pa/template-instantiator.spec.js:
2) TemplateInstantiator
creates structure for shared files (verbose) at (81)
o365/pa/template-instantiator.spec.js:

Steps to reproduce

• I have pulled the latest upstream and using node version 12.14.1 (to create a new branch, no code changes yet)
• Have cleaned the node_modules prior and done a fresh npm install
• Did npm clean, build before running npm test

Expected result

All tests passed, 100% coverage

Actual result

7529 passing (7s)
2 failing
Coverage report still shows 100%

Environment

• Using macOs 10.13
• node version 12.14.1

[rabwill]

@garrytrinder Not sure what I am doing wrong may be a little help here to understand why tests are failing on a fresh new branch pulled from upstream?

[garrytrinder]

Hey @rabwill 👋🏻

I've just updated my fork following the latest release this weekend and i'm not getting any failing tests on MacOS Mojave v10.15.2 on Node v12.12.0.

Could you share the error messages you get for the failing tests?

[waldekmastykarz]

@rabwill before running tests, have you done npm run build or npm run watch?

[rabwill]

Hey guys, yes I ran an npm clean and build before running the test. Hmm strange may be I will run an npm clean cache may be and change the node version to Garry’s and try again tonight. Thank you !

[waldekmastykarz]

Hey @rabwill, is this still an issue?

[rabwill]

Hey @rabwill, is this still an issue?

Hey @waldekmastykarz you can close this. I found the issue to be from my end, I did not rebase my dev with upstream but only pulled it.
I found a file in pa folder not part of the upstream dev and knew this was the issue.
Please close this :)

[waldekmastykarz]

Thank you for confirming and good to hear you're not blocked by it 👍