Cli-microsoft365: Update documentation to reflect required Node version
With the release of v2.5, we changed from istanbuljs (nyc) to using c8 as our test coverage tool.
This change now means that we no longer support older versions of Node when contributing to the CLI, we now require v12 or higher.
We should update our documentation to reflect this change.
garrytrinder
All 5 comments
package.json is not the right place to do it, because it would indicate that you need Node@12 to use the CLI. We require Node@12 only when contributing to it to run tests using c8. You should be be able to use the CLI with older Node versions as well though. So instead, we should include the reference in the docs directed at contributors.
waldekmastykarz
on 12 Jan 2020
Good spot @waldekmastykarz 馃憤馃徎
I have updated the issue description.
garrytrinder
on 12 Jan 2020
Coming back to this, the c8 docs state that the version of node required is >= 10.12.0 not 12 so will update our docs based on this.
https://github.com/bcoe/c8#supported-nodejs-versions
garrytrinder
on 9 Mar 2020
v10 is the minimum, but some of our tests fail if you don't run them on v12 馃槉
waldekmastykarz
on 10 Mar 2020
Updated 馃憤馃徎
garrytrinder
on 10 Mar 2020
Related issues
vineet2907
路
3Comments
rabwill
路
3Comments
waldekmastykarz
路
3Comments
phillipharding
路
3Comments
waldekmastykarz
路
3Comments
Most helpful comment
package.jsonis not the right place to do it, because it would indicate that you need Node@12 to use the CLI. We require Node@12 only when contributing to it to run tests using c8. You should be be able to use the CLI with older Node versions as well though. So instead, we should include the reference in the docs directed at contributors.