Cli-microsoft365: ClientSideInstance.xml missing while upgrading from 1.5.0 with cli 1.19.0

[PiWiBardy]

Hello,

While upgrading a solution from SPFX version 1.5.0 to 1.7.1 and finally to 1.8.2, there's no creation of the file sharepoint/assets/ClientSideInstance.xml, and if it's missing the custom action is not activated on the site after the package deployment.

if we're initializing a project in SPFX 1.8.2 the file is created.

Steps To Reproduce:

• Create a Extension Project with SPFX 1.5.0
• Upgrade it to 1.7.1
• Upgrade it to 1.8.2

Thanks for your help.

[waldekmastykarz]

Thank you for reporting the issue and the details. I'll try to repro it and will get back to you as soon as I know more.

[waldekmastykarz]

You're right: the CLI doesn't suggest adding the file. The tricky part, and I believe the reason why we haven't added it initially, is that it would change the characteristic of your solution. Where originally it would not support tenant-wide deployment, after adding this file it would, without it being an explicit choice on your part.

I'm open for a discussion and arguments if you think this behavior should be changed 🙂

[PiWiBardy]

Hi @waldekmastykarz ( sorry for the delay ),

As per my understanding of the post https://github.com/SharePoint/sp-dev-docs/issues/3690 by @andrewconnell the tenant-wide deployment is only triggered if we have the ClientSideInstance.xml file & the skipFeatureDeployment setting set to true.

So what about a suggest about adding the file only if the skipFeatureDeployment is set to true, with a warning on the effects on the project?

[waldekmastykarz]

What if we added is an optional update step? So, the person upgrading the project can choose if they want to apply it or not?

[PiWiBardy]

It sounds better than my solution ;) as expected from you haha

Sent from My iPhone

---

De : Waldek Mastykarz [e-mail]
Envoyé : Tuesday, May 21, 2019 7:23:51 PM
À : pnp/office365-cli
Cc : Pierre-Yves Bardy; Author
Objet : Re: [pnp/office365-cli] ClientSideInstance.xml missing while upgrading from 1.5.0 with cli 1.19.0 (#972)

What if we added is an optional update step? So, the person upgrading the project can choose if they want to apply it or not?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pnp/office365-cli/issues/972?email_source=notifications&email_token=AAO35KLNAY77SUAEPLFICCTPWQV2PA5CNFSM4HNCL4WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV4TKFI#issuecomment-494482709, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAO35KOCPSD6PONULXBAOK3PWQV2PANCNFSM4HNCL4WA.

[waldekmastykarz]

It takes two to arrive to it. I would've never given it a thought if it wasn't for your comment 👏