Cli-microsoft365: New command: Remove an app from a Microsoft Team

[vman]

Remove an app from a Microsoft Team

• command: graph teams app remove -id|--appId -i|--teamId
• appId: Id of the app from the catalog, returned from the graph teams app list command
• teamId: Id of the team from which to remove the app
• Graph API endpoint: https://docs.microsoft.com/en-us/graph/api/teamsappinstallation-delete?view=graph-rest-1.0

[vman]

Hi @waldekmastykarz, feel free to assign this one and #842 to me :)

[waldekmastykarz]

Nice suggestion @vman! Unfortunately, we already have a command with this name which is now used to remove the app from the catalog. Did you mean to extend the existing command or introduce a new one?
Similarly to #842, short options can consist of a single letter, so we can't do -id. Because the command has two IDs, I wonder if we should use the short -i at all or if we should use the long versions which are more explicit. Also, following the convention, all remove commands should have the --confirm option which allows to suppress prompting for confirmation before executing the deletion.

[vman]

Ok makes sense to have the --confirm option.

Yes I noticed that there is a graph teams app remove command already. Either we update it to add a --teamId option or create a new command entirely e.g. graph teams app removefromteam.

If we go with the first option, there could be confusion if someone forgets to add the --teamId option and the app is removed from the entire catalog (which will remove it from all teams)

The later option makes it more explicit that the app will be removed from the team and not from the catalog.

[waldekmastykarz]

Looking at the API, I see that it mentions installation and installed apps. Would it make sense to use install and uninstall instead of add and remove when it comes to instances of app in teams?

[vman]

Let's go with graph teams app uninstall --appId --teamId

[waldekmastykarz]

Game on!