Cli-microsoft365: New command: add a Microsoft Team

Created on 21 Sep 2018  路  16Comments  路  Source: pnp/cli-microsoft365

Create a new MIcrosoft Teams team

We have two options:
1) using the o365group add and teams add - that is first create the group and then add a team to it. Which is how Microsoft Graph works and how the API's is exposed.

command; teams add --groupId <groupId> [..additional settings]
groupId: id of the group

OR

2) using just teams add which would optionally take a group id as parameter, if a group exists it adds the team to that group otherwise it creates a new group and add the team to that. This is a more complex and non-atomic operation.

command; teams add -[-groupId <groupId>] [..additional settings]
groupId: id of the group

Thoughts?

good first issue new feature work in progress

All 16 comments

I'd vote for 2). Even if creating the team would fail, you could still add it afterwards by passing the ID of the group created previously.

@wictorwilen how are you going with this one? Can I help on this?

@rfjschouten if you're still interested, feel free to pick it up.

@rfjschouten are you working on this or is it free for picking?

Setting as free for picking due to lack of response

Can I work on this?

Of course! All yours!

Hey @kshsbala are you still working on this one?

Setting as available for taking due to lack of response

Hi @waldekmastykarz, somehow missed the notification for the above. If it is still available...I can look into this.

Sure thing, still available and all yours 馃憤

Are we going with the Option 2 - Create group if doesnt exist and add a team. We have a command to create a group which takes displayName, description, mailNickName as a mandatory parameters. Wondering whether to call the command or use the helper method here to create the group before creating the team.

Let's go with 2 indeed. I wouldn't call the command internally as there is some odd mechanics behind it. If there is common functionality, let's put it in a common place and reuse.

Thanks @waldekmastykarz. Started creating the common method for both and will let you know once it is completed.

Hi @waldekmastykarz, My initial pull request had a conflict which I resolved it now. But couldnt able to update my initial pull request.

No problem. Thanks for catching it!

Was this page helpful?
0 / 5 - 0 ratings